[chrome] don't touch default min sdk version #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
target `all_jdk_libs` will call [r8 to shrink the code-size][1] and use `default_min_sdk_version` as value of argument of "--min-api". In this version r8 fails when min api >=26. So we should not set argument of `default_min_sdk_version`, instead we can directly set argument of `android64_ndk_api_level`, which gn will use to set the cflag of "--target". Setting argument of `default_min_sdk_version` also can change the default value of `android64_ndk_api_level`, but now seems it is not the correct place because it will impact other logic, such as r8. Test: make ninja T=build/android:all_jdk_libs [1]:https://nphausg.medium.com/android-journey-proguard-d8-r8-what-are-they-e8f2bfe079a7 Signed-off-by: Wang Chen <wangchen20@iscas.ac.cn>
McKnight22
approved these changes
Mar 6, 2023
unicornx
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
target
all_jdk_libswill call r8 to shrink the code-size and usedefault_min_sdk_versionas value of argument of "--min-api". In this version r8 fails when min api >=26.So we should not set argument of
default_min_sdk_version, instead we can directly set argument ofandroid64_ndk_api_level, which gn will use to set the cflag of "--target".Setting argument of
default_min_sdk_versionalso can change the default value ofandroid64_ndk_api_level, but now seems it is not the correct place because it will impact other logic, such as r8.Test: make ninja T=build/android:all_jdk_libs