Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Produce an error if SRCS contains an invalid path. #18

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

KholdStare
Copy link
Contributor

Hi Andrzej,

Previously, all wrong entries in SRCS would be silently filtered out. This change aims to keep Rules.mk files accurate, and easier to debug.

Thanks!

Previously, all wrong entries would be silently filtered out.
@aostruszka
Copy link
Owner

Hello Alex

I would like to merge your changes however there is one thing that bothers me. What if the source which one gives to SRCS is being generated from some other file - like lex.c from lex.l or grammar.c from grammar.y. I haven't checked but it seems that your solution will raise an error before generating rules while we should be giving make chance to figure out how to produce it.

Maybe instead of raising an error we should be passing source unchanged or automatically replacing .c/.cpp into .o and letting make to signal an error.

Best regards
Andrzej

@KholdStare
Copy link
Contributor Author

Hi Andrzej

Yes, you are right! I'll think about it, and see if it is possible to delay the check till the target is built.

Perhaps using = for lazy evaluation instead of := could help?

Regards,
Alex.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants