fix lighthouse feedback (#75)

aotearoan · Dec 6, 2020 · 838dc44 · 838dc44
1 parent 99bae40
commit 838dc44
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 1 deletion.
diff --git a/package.json b/package.json
@@ -1,7 +1,7 @@
 {
   "name": "@aotearoan/neon",
   "description": "Neon is a lightweight design library of VueJS components with minimal dependencies. It supports light and dark modes and can be extended to support multiple themes",
-  "version": "4.0.7",
+  "version": "4.0.8",
   "main": "dist/@aotearoan/neon.umd.js",
   "types": "dist/@aotearoan/components.d.ts",
   "files": [

diff --git a/src/app/App.vue b/src/app/App.vue
@@ -59,6 +59,7 @@
               color="high-contrast"
               button-style="text"
               :size="isMobile ? 's' : 'l'"
+              aria-label="View on GitHub"
             />
             <neon-button
               name="dark-mode-toggle"

diff --git a/src/components/navigation/link/NeonLink.vue b/src/components/navigation/link/NeonLink.vue
@@ -28,6 +28,7 @@
     tabindex="0"
     @click="onClick"
     @keydown.enter="onClick"
+    rel="noopener"
   >
     <span class="neon-link__label">
       <!-- @slot the content of the link -->