Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More Precise Colors #17

Closed
wants to merge 2 commits into from
Closed

More Precise Colors #17

wants to merge 2 commits into from

Conversation

sencer
Copy link

@sencer sencer commented Apr 24, 2012

I reported an issue about not-so-precise colors. With the striking example of " #46a546". This "not even a little elegant" solution of mine kind of resolves the issue.

I would also suggest looking at chrisbra/color_highlight, which does the color highlighting much better -but only on demand.

@ap
Copy link
Owner

ap commented Apr 24, 2012

Regarding the second commit, sorry, I’m not going to turn this script into a clone of color_highlight. If you want color_highlight then use color_highlight.

I also don’t like to just dump a huge lookup table into the code with no indication of where the values came from – the approach itself may work well but then I’d like to have a build process with a program that pre-calculates the table. So I’m afraid I won’t be taking the first commit verbatim either.

And in either case I’m not interested in a complete re-indenting of the script for no apparent reason.

However – I’ve fetched the commits and will look over the code for inspiration. Thanks.

@ap ap closed this Apr 24, 2012
@sencer
Copy link
Author

sencer commented Apr 25, 2012

I’ve fetched the commits and will look over the code for inspiration

this was the reason I sent the request.

@ap ap mentioned this pull request Mar 9, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants