Fix CONTINUE and STOP queries with implicit DB #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielcompton
force-pushed
the
fix-implicit-db-with-changefeeds
branch
from
ac1acbb
to
4a43eba
Compare
- Fix handling of CONTINUE and STOP queries. Global optargs from the db connection were being appended to every query that was being sent if the db parameter was set on the connection. START queries have two elements in the vector: query type (START), and query. However CONTINUE and STOP queries only have a single query type in the vector, so the global optargs were getting appended as the second element in these vectors. This caused RethinkDB to throw an error as we weren't sending a valid query. - Update changelog - Add failing tests that pass with this fix.
danielcompton
force-pushed
the
fix-implicit-db-with-changefeeds
branch
from
4a43eba
to
53cea15
Compare
danielcompton
added a commit
that referenced
this pull request
Jul 2, 2015
Fix CONTINUE and STOP queries with implicit DB
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
connection were being appended to every query that was being sent if
the db parameter was set on the connection. START queries have two
elements in the vector: query type (START), and query. However
CONTINUE and STOP queries only have a single query type in the vector, so
the global optargs were getting appended as the second element in
these vectors. This caused RethinkDB to throw an error as we weren't
sending a valid query.
To avoid these kinds of bugs in the future, it could be good to turn the query vector into a map with named elements.