Convert to cljc and reader conditionals

[danielcompton]

New attempt, based on #26.

• Commenting out time related queries because I haven't picked a clj-time replacement for the ClojureScript port (cljs-time looks promising though). -> Support order-by query term in cljs #65
• Handle UUID's. It looks like this might be the best option. I would have expected something from Google Closure for this though. Also worth looking at this gist. I think there was a recent release of cljs which supports UUID's as well. -> Support order-by query term in cljs #65
• Properly handle fn's -> Support rethinkdb.query/fn in CLJS #64
• Check Regexs are correct, probably need platform specific versions

[danielytics]

So am I correct in saying that the goal here is that rethinkdb.query is available from cljs so that the queries can be constructed in cljs (but actually sending the queries and receiving results is clj only, so only query.clj and query_builder.clj need to be ported)?

I would suggest maybe adding a build function to rethinkdb.query that calls replace-vars and then modifying run to optionally take a prebuilt query.

[danielcompton]

I need to check this, but I'm pretty sure we won't need to modify run at all. Calling (-> (r/db) (r/table :users)) will generate EDN data. That can be shipped across to the server where it calls (r/run client-query conn).

[danielcompton]

Regex's aren't being used anymore on the shared path after b1433fa.

[danielcompton]

I've merged this into master. There are however a few caveats:

• fn isn't supported in CLJS
• order-by isn't supported in CLJS

I'll open tickets to fix these separately.

[danielytics]

I suppose it depends on if you want to call replace-vars as part of the AST building, or as part of running (on the server, later). If you're happy with the latter, then it works as is.

Great work, btw.

[danielcompton]

I haven't really looked at fn, what's the difference between doing it on the client or server?

[danielytics]

Nothing much, its just a question of do you want to prepare the query as much as possible (ie the AST is as baked and prepared as possible) or if you just care that the representation is captured.

If you don't want to, say, store the most processed form of a query ready to send to the RethinkDB server and only care that you can create queries from cljs (and store them or whatever), then no changes are necessary.

All replace-vars does is make sure that unique integer ID's are assigned to variables that shadow others of the same name in nested scopes.

I suspect the answer is that you just want to be able to generate the query in cljs but don't care that (slightly) more processing is needed before running the query :) so I don't think anything needs to be done. I just wanted to check to be sure.

[danielcompton]

Right, makes sense. Probably just as easy to leave it to be done on the server, it should have an added benefit of being slightly easier to debug if we have variable names in them.

[danielytics]

Agreed. Like I said, I just wanted to make sure it was thought about. I don't mind which way you choose, but you're right that doing it on the server would be better for debugging, so lets do that.

[arichiardi]

Hello guys, sorry if I write in a closed issue, but how to start with ClojureScript? I tried [rethinkdb.query :as r :include-macros true] but I saw there is an IllegalArgumentException no in a clj block in there. Shall I patch it? Maybe the question is more like, what is this namespace missing in terms of reader conditionals?

[apa512]

A patch would be great. IllegalArgumentException is probably the only thing that has to be changed. I totally forgot about ClojureScript when adding that.