Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Appleskin Compatibility #186

Merged
merged 9 commits into from
May 19, 2024
Merged

Conversation

MerchantPug
Copy link
Contributor

@MerchantPug MerchantPug commented Nov 24, 2023

Unfortunately, I've had to provide a mixin as the API does not support changing the check for if an item is edible or not. But other than this, I've tested the game with and without AppleSkin on the client.

This PR adds support to AppleSkin for the following power types:

  • Edible Item
  • Modify Food
  • Prevent Item (for food)

@MerchantPug
Copy link
Contributor Author

I've accidentally screwed with the indentation of the mixin json, my bad.

@eggohito eggohito added this to the 2.12.x milestone Dec 22, 2023
@eggohito eggohito changed the base branch from 1.20 to 1.20.4/dev May 17, 2024 04:41
* Now uses the `PotentiallyEdibleItemStack` for querying the stack's modified food component
* Now only collects powers that use the `modify_food` power types conditionally once and map the elements accordingly
@eggohito eggohito added the to merge This will be merged soon label May 19, 2024
@eggohito eggohito merged commit 0522d0c into apace100:1.20.4/dev May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
to merge This will be merged soon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants