Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflict with Azurelib Armor #43

Open
MeatVegetalbe opened this issue Nov 29, 2023 · 4 comments
Open

Conflict with Azurelib Armor #43

MeatVegetalbe opened this issue Nov 29, 2023 · 4 comments

Comments

@MeatVegetalbe
Copy link

I've been testing mods, and I found that armours using Azurelib Armor show as a pink error texture when put in the cosmetic slot. Not sure what could be causing this, however that is the only consistency with the issue.

@MeatVegetalbe
Copy link
Author

@AzureDoom
Copy link

This would be on Cometic Armor, most likely https://github.com/apace100/cosmetic-armor/blob/1.20/src/main/java/io/github/apace100/cosmetic_armor/mixin/MixinCosmeticArmorVisibility.java#L87-L88C43 to be exact. I sugguest using WrapOperation https://github.com/LlamaLad7/MixinExtras/wiki/WrapOperation instead of a Redirect for this issue @apace100. I am doing a custom build on my end just to confirm this and will send in a PR if you open to it. The latest Fabric loader does add Mixin Extras in Fabric now but if you wish to target older versions as well, it must be included.

@MeatVegetalbe
Copy link
Author

Thanks Azure

@DoloSaber
Copy link

This would be on Cometic Armor, most likely https://github.com/apace100/cosmetic-armor/blob/1.20/src/main/java/io/github/apace100/cosmetic_armor/mixin/MixinCosmeticArmorVisibility.java#L87-L88C43 to be exact. I sugguest using WrapOperation https://github.com/LlamaLad7/MixinExtras/wiki/WrapOperation instead of a Redirect for this issue @apace100. I am doing a custom build on my end just to confirm this and will send in a PR if you open to it. The latest Fabric loader does add Mixin Extras in Fabric now but if you wish to target older versions as well, it must be included.

Hi, I tried several times to fix this bug, but I'm not good at java and I always get error, is there any other way to fix it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants