Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

origins:exposed_to_sun doesnt work properly with shader powers #745

Open
CammiePone opened this issue Apr 13, 2024 · 2 comments
Open

origins:exposed_to_sun doesnt work properly with shader powers #745

CammiePone opened this issue Apr 13, 2024 · 2 comments
Assignees
Labels
bug Something isn't working to backport This issue has been fixed in the newer versions.

Comments

@CammiePone
Copy link

CammiePone commented Apr 13, 2024

So I tried making an origin that would have the phosphor shader applied to their screen when in direct sunlight, but uh... it still applies at night, throughout the entire night.

My guess is because sky light is still at 15 during the night.

I'm currently running on latest for 1.20.1

@eggohito
Copy link
Collaborator

This has already been fixed in Origins 1.12.5 (for Minecraft 1.20.2). This was due to the ambient darkness of the world in the client only being calculated once; this also affected the brightness entity condition type and the light_level block condition type (if light_type is not specified.)

@eggohito
Copy link
Collaborator

I won't be closing this issue since a backport for 1.20.1 is planned, but there are current circumstances that's blocking it, so it may take a while

@eggohito eggohito added the bug Something isn't working label Apr 14, 2024
@eggohito eggohito self-assigned this Apr 14, 2024
@eggohito eggohito added the to backport This issue has been fixed in the newer versions. label Apr 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working to backport This issue has been fixed in the newer versions.
Projects
None yet
Development

No branches or pull requests

2 participants