Added texture field to origins. #702
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved background.png to background/window.png. Added screen.png, as a default screen background acting as the default dirt texture.
eggohito
requested changes
Oct 22, 2023
| @@ -33,13 +34,14 @@ public class Origin { | |||
| .add("impact", OriginsDataTypes.IMPACT, Impact.NONE) | |||
| .add("loading_priority", SerializableDataTypes.INT, 0) | |||
| .add("upgrades", OriginsDataTypes.UPGRADES, null) | |||
| .add("textures", ApoliDataTypes.IDENTIFIER_MAP, new LinkedHashMap<>()) | |||
There was a problem hiding this comment.
I think the name of the field should be texture_map, just to be consistent with the texture_map field of the status_bar_texture power type that behaves the same
There was a problem hiding this comment.
oh yeah for sure, i forgot to check the name of the existing one, will change when i'm able to
There was a problem hiding this comment.
Just a minor nitpick: I think this util. class could be generalized for checking if a texture is loaded or if a sprite exists in an atlas, similar to what I did in my dynamic container type PR in Apoli
* The contents of the origin screen now looks a lot more seamless, where the text renders behind the window border frame and the window name plate * Simplified how the origin name widget is rendered
… power type * The action is now only executed if the entity condition specified in the power's `condition` field is fulfilled or absent
* Now accounts for layers that do not have any options (e.g: if a layer automatically chooses an origin conditionally, and if that condition is not fulfilled)
* Fixed Arachnid unable to hold its climb on sneak * Fixed Arachnid unable to go down on sneak while climbing cobweb-like blocks + Added NOT sneaking condition for webbing attacked entities
* Added a set of condition that evaluates whether the entity is not sneaking and if it's horizontally colliding with a block; to keep the old behavior of climbing
For some reason, writing to a buffer directly and using the Networking v1 API works for both singleplayer and multiplayer, while using the object-oriented Networking API (v2) doesn't 🤔
..where the result stack is not being modified by a power that uses the `modify_crafting` power type
Caused by trying to get a non-existent origin layer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates a textures field in the origin json files which can be used to replace any GUI element with a custom texture.
To avoid missing texture issues, the default textures are also used as fallback textures if the specified identifier does not exist in the gui sprite atlas.