Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unhardcode some powers of certain origins #755

Merged
merged 2 commits into from
May 26, 2024

Conversation

eggohito
Copy link
Collaborator

@eggohito eggohito commented May 26, 2024

This PR adds new power types to be used in place of the simple power type in some powers of certain origins, such as Merling and Feline, for further re-usability of the powers in custom origins.

The power types currently does not provide fields for customization (but all of it still supports the condition field), and will likely never have such fields as these power types are essentially just the precursor for its corresponding generalized types that may be implemented in the future (if possible to implement.)

These are the power types that will be added by this PR:

Type Description
origins:like_water Prevents the entity from sinking to the ground when underwater if the entity doesn't have downwards velocity.
origins:water_breathing Makes the entity only be able to breathe underwater.
origins:scare_creepers Scares away creepers within 6-blocks cuboid radius.
origins:water_vision Prevents the slight reduction on the player's vision when just submerging into water.
origins:conduit_power_on_land Makes the player receive the "Conduit Power" status effect from active Conduits even if the player is not touching water.

The newly added power types do not currently add customizability for its functionality. Ideally, a generalized version of these types should be introduced, but as is, it should be good for now.
@eggohito eggohito changed the title Feat/misc/unhardcoded powers Unhardcode some powers of certain origins May 26, 2024
@eggohito eggohito added this to the 1.13.x milestone May 26, 2024
@eggohito eggohito merged commit 84687b6 into 1.20.4/dev May 26, 2024
@eggohito eggohito deleted the feat/misc/unhardcoded_powers branch May 26, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant