Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

chore: bump deckgl and mapbox libs #41

Merged
merged 1 commit into from
Aug 10, 2021

Conversation

villebro
Copy link
Contributor

🐛 Bug Fix

The deckgl plugin started crashing my browser, and bumping both the deck.gl and mapbox-gl packages to the latest stable versions seemed to fix the problem (currently on 2 years old versions).

AFTER

image

BEFORE

image

@villebro villebro requested a review from a team as a code owner August 10, 2021 07:48
@kgabryje
Copy link
Contributor

It's a pretty big bump. Are there no breaking changes?

"react": "^15 || ^16"
"@superset-ui/chart-controls": "^0.17.80",
"@superset-ui/core": "^0.17.80",
"react": "^16.13.1"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

react-map-gl requires >=16.3. Also, this is what superset-ui requires.

Copy link
Contributor

@zhaoyongjie zhaoyongjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@villebro
Copy link
Contributor Author

It's a pretty big bump. Are there no breaking changes?

This is the biggest change that we need to be wary of (bumping to 1.0 means opting in to the new pricing model): https://blog.mapbox.com/new-pricing-46b7c26166e7

Copy link
Contributor

@kgabryje kgabryje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@villebro villebro merged commit 41ace99 into apache-superset:master Aug 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants