Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

fix(hex): restore control panel to functioning state #42

Merged

Conversation

villebro
Copy link
Contributor

馃悰 Bug Fix
During migration of control panels to this repo in #17 the Hex control panel was apparently created incorrectly. This PR restores the Hex control panel to those that were removed from apache/superset in apache/superset#11564 with minor refactoring to correspond with shared controls available in this repo.

AFTER

image

BEFORE

image

@villebro villebro requested a review from a team as a code owner August 19, 2021 08:12
Comment on lines -55 to +49
// TODO [autozoom, null], // import { autozoom } from './Shared_DeckGL'
],
},
{
label: t('GeoJson Settings'),
controlSetRows: [
[fillColorPicker, strokeColorPicker],
[filled, stroked],
[extruded, null],
['color_picker'],
[autozoom],
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I decided to add the autozoom control as it appears to be used elsewhere, too. To make the behavior unchanged in the example chart, I'm adding autozoom: false to the chart metadata in the PR that bumps the version of this plugin on the main repo (forthcoming).

Copy link
Contributor

@kgabryje kgabryje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@villebro villebro merged commit 165a516 into apache-superset:master Aug 19, 2021
@villebro villebro deleted the villebro/hex-control-panel branch August 19, 2021 10:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants