This repository has been archived by the owner on Dec 10, 2021. It is now read-only.
fix(hex): restore control panel to functioning state #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
villebro
commented
Aug 19, 2021
Comment on lines
-55
to
+49
| // TODO [autozoom, null], // import { autozoom } from './Shared_DeckGL' | ||
| ], | ||
| }, | ||
| { | ||
| label: t('GeoJson Settings'), | ||
| controlSetRows: [ | ||
| [fillColorPicker, strokeColorPicker], | ||
| [filled, stroked], | ||
| [extruded, null], | ||
| ['color_picker'], | ||
| [autozoom], |
There was a problem hiding this comment.
I decided to add the autozoom control as it appears to be used elsewhere, too. To make the behavior unchanged in the example chart, I'm adding autozoom: false to the chart metadata in the PR that bumps the version of this plugin on the main repo (forthcoming).
9 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃悰 Bug Fix
During migration of control panels to this repo in #17 the Hex control panel was apparently created incorrectly. This PR restores the Hex control panel to those that were removed from
apache/supersetin apache/superset#11564 with minor refactoring to correspond with shared controls available in this repo.AFTER
BEFORE