This repository has been archived by the owner on Jun 25, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 77
Commits on Feb 29, 2020
-
feat: faster legacy table chart
This commit tries to optimize the performance of the legacy data table. 1. Converting everything to Typescript. 2. Create a native React component instead of `reactify` (although all DOM operaions still happen in the jQuery.DataTables plugin. 3. Remove dependency on d3, optimize how bars are rendered. Plus some minor changes to fix linting and building. Also added a script to build only specific plugin for faster development.
Configuration menu - View commit details
-
Copy full SHA for a37bd8c - Browse repository at this point
Copy the full SHA a37bd8cView commit details
Commits on Mar 2, 2020
-
feat(legacy-table-chart): use React to render DOM
Unfortunately jquery.datatables uses innerHTML to create cell content, and all rows are created even with pagination. https://github.com/DataTables/DataTables/blob/83657a29e33ce93ee940ce25684940eb3acb2913/media/js/jquery.dataTables.js#L3113-L3117 This is slow and insecure. We are reverting to DOM data source as in previous implementation, but instead of using D3 to create the table rows, we use React. This also renders `dompurify.sanitize` unnecessary since React will take care of it.
Configuration menu - View commit details
-
Copy full SHA for 7f6382d - Browse repository at this point
Copy the full SHA 7f6382dView commit details
Commits on Mar 3, 2020
-
feat(legacy-table-chart): support html in data cells
Also 1. improve height adjustment 2. add page size control to storybook 3. hide rows from later pages at initial rendering
Configuration menu - View commit details
-
Copy full SHA for 5f0308d - Browse repository at this point
Copy the full SHA 5f0308dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 866d80c - Browse repository at this point
Copy the full SHA 866d80cView commit details -
chore(legacy-table): add xss dependency
Plus minor variable name and comment update
Configuration menu - View commit details
-
Copy full SHA for f20e01b - Browse repository at this point
Copy the full SHA f20e01bView commit details
Commits on Mar 4, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 5ab1e43 - Browse repository at this point
Copy the full SHA 5ab1e43View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3ec8414 - Browse repository at this point
Copy the full SHA 3ec8414View commit details -
Configuration menu - View commit details
-
Copy full SHA for b6b7e1c - Browse repository at this point
Copy the full SHA b6b7e1cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5cb7730 - Browse repository at this point
Copy the full SHA 5cb7730View commit details -
Configuration menu - View commit details
-
Copy full SHA for 95eb028 - Browse repository at this point
Copy the full SHA 95eb028View commit details -
Configuration menu - View commit details
-
Copy full SHA for b1619d2 - Browse repository at this point
Copy the full SHA b1619d2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2c903f3 - Browse repository at this point
Copy the full SHA 2c903f3View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.