Skip to content
This repository has been archived by the owner on Jun 25, 2020. It is now read-only.

perf: faster legacy table chart #385

Merged
merged 12 commits into from
Mar 5, 2020

Commits on Feb 29, 2020

  1. feat: faster legacy table chart

    This commit tries to optimize the performance of the legacy data table.
    
    1. Converting everything to Typescript.
    2. Create a native React component instead of `reactify` (although all
       DOM operaions still happen in the jQuery.DataTables plugin.
    3. Remove dependency on d3, optimize how bars are rendered.
    
    Plus some minor changes to fix linting and building.
    
    Also added a script to build only specific plugin for faster
    development.
    ktmud committed Feb 29, 2020
    Configuration menu
    Copy the full SHA
    a37bd8c View commit details
    Browse the repository at this point in the history

Commits on Mar 2, 2020

  1. feat(legacy-table-chart): use React to render DOM

    Unfortunately jquery.datatables uses innerHTML to create cell content,
    and all rows are created even with pagination.
    
    https://github.com/DataTables/DataTables/blob/83657a29e33ce93ee940ce25684940eb3acb2913/media/js/jquery.dataTables.js#L3113-L3117
    
    This is slow and insecure. We are reverting to DOM data source as in
    previous implementation, but instead of using D3 to create the table rows,
    we use React. This also renders `dompurify.sanitize` unnecessary since
    React will take care of it.
    ktmud committed Mar 2, 2020
    Configuration menu
    Copy the full SHA
    7f6382d View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2020

  1. feat(legacy-table-chart): support html in data cells

    Also
    
    1. improve height adjustment
    2. add page size control to storybook
    3. hide rows from later pages at initial rendering
    ktmud committed Mar 3, 2020
    Configuration menu
    Copy the full SHA
    5f0308d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    866d80c View commit details
    Browse the repository at this point in the history
  3. chore(legacy-table): add xss dependency

    Plus minor variable name and comment update
    ktmud committed Mar 3, 2020
    Configuration menu
    Copy the full SHA
    f20e01b View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2020

  1. Configuration menu
    Copy the full SHA
    5ab1e43 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3ec8414 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b6b7e1c View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    5cb7730 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    95eb028 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    b1619d2 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    2c903f3 View commit details
    Browse the repository at this point in the history