This repository has been archived by the owner on Jun 25, 2020. It is now read-only.
fix(legacy-table): container height on tall headers #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kristw
approved these changes
Mar 11, 2020
Codecov Report
@@ Coverage Diff @@
## master #398 +/- ##
=========================================
+ Coverage 2.8% 2.83% +0.03%
=========================================
Files 186 186
Lines 5813 5813
Branches 372 373 +1
=========================================
+ Hits 163 165 +2
Misses 5623 5623
+ Partials 27 25 -2
Continue to review full report at Codecov.
|
|
Deploy preview for superset-ui-plugins ready! Built with commit 48e0f8a |
nytai
pushed a commit
to preset-io/superset-ui-plugins
that referenced
this pull request
Apr 27, 2020
lexisstv
pushed a commit
to utrace-ltd/superset-ui-plugins
that referenced
this pull request
Jun 1, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous change used fixed heights for those controls, as is in the new lunar data table chart implementation. It turns this breaks things. The table's scroll body overflows when header or search/pagination controls are too tall.
This fix reverts back to parsing heights from the rendered DOM elements.
Test Plan
After the fix, there should be some whitespace between table container and the root.
馃悰 Bug Fix