fix(legacy-preset-chart-nvd3): stacked bar charts labels (#40)

* fix(legacy-preset-chart-nvd3): stacked bar charts labels * fix(legacy-preset-chart-nvd3): fix lint
apache-superset · Apr 4, 2019 · 744f7c8 · 744f7c8
1 parent 9a9337a
commit 744f7c8
Show file tree

Hide file tree

Showing 2 changed files with 41 additions and 1 deletion.
diff --git a/plugins/superset-ui-plugins/packages/superset-ui-legacy-preset-chart-nvd3/src/utils.js b/plugins/superset-ui-plugins/packages/superset-ui-legacy-preset-chart-nvd3/src/utils.js
@@ -50,7 +50,7 @@ export function getTimeOrNumberFormatter(format) {
 
 export function drawBarValues(svg, data, stacked, axisFormat) {
   const format = getNumberFormatter(axisFormat);
-  const countSeriesDisplayed = data.length;
+  const countSeriesDisplayed = data.filter(d => !d.disabled).length;
 
   const totalStackedValues =
     stacked && data.length !== 0

diff --git a/...kages/superset-ui-plugins-demo/storybook/stories/legacy-preset-chart-nvd3/Bar/Stories.jsx b/...kages/superset-ui-plugins-demo/storybook/stories/legacy-preset-chart-nvd3/Bar/Stories.jsx
@@ -126,4 +126,44 @@ export default [
     storyName: 'Bar with positive and negative values',
     storyPath: 'legacy-|preset-chart-nvd3|BarChartPlugin',
   },
+  {
+    renderStory: () => (
+      <SuperChart
+        chartType="bar"
+        chartProps={{
+          datasource: {
+            verboseMap: {},
+          },
+          formData: {
+            barStacked: true,
+            bottomMargin: 'auto',
+            colorCcheme: 'd3Category10',
+            contribution: false,
+            groupby: ['region'],
+            lineInterpolation: 'linear',
+            metrics: ['sum__SP_POP_TOTL'],
+            richTooltip: true,
+            showBarValue: true,
+            showBrush: 'auto',
+            showControls: false,
+            showLegend: true,
+            stackedStyle: 'stack',
+            vizType: 'bar',
+            xAxisFormat: '%Y',
+            xAxisLabel: '',
+            xAxisShowminmax: false,
+            xTicksLayout: 'auto',
+            yAxisBounds: [null, null],
+            yAxisFormat: '.3s',
+            yLogScale: false,
+          },
+          height: 400,
+          payload: { data },
+          width: 400,
+        }}
+      />
+    ),
+    storyName: 'Stacked bar with values',
+    storyPath: 'legacy-|preset-chart-nvd3|BarChartPlugin',
+  },
 ];