fix: unset row_limit when it's not a number (#387)

* fix: unset row_limit when it's not a number * fix: address comments
apache-superset · Apr 22, 2020 · 98b6117 · 98b6117 · vercel · Apr 22, 2020
1 parent a95301f
commit 98b6117
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/packages/superset-ui-query/src/buildQueryObject.ts b/packages/superset-ui-query/src/buildQueryObject.ts
@@ -33,6 +33,7 @@ export default function buildQueryObject<T extends QueryFormData>(formData: T):
   } = formData;
 
   const groupbySet = new Set([...columns, ...groupby]);
+  const numericRowLimit = Number(row_limit);
 
   const queryObject: QueryObject = {
     extras: processExtras(formData),
@@ -42,7 +43,7 @@ export default function buildQueryObject<T extends QueryFormData>(formData: T):
     metrics: processMetrics(formData),
     order_desc: typeof order_desc === 'undefined' ? true : order_desc,
     orderby: [],
-    row_limit: Number(row_limit),
+    row_limit: row_limit == null || isNaN(numericRowLimit) ? undefined : numericRowLimit,
     since,
     time_range,
     timeseries_limit: limit ? Number(limit) : 0,