Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

feat: include control panel in the chart plugin #203

Merged
merged 1 commit into from
Aug 14, 2019
Merged

feat: include control panel in the chart plugin #203

merged 1 commit into from
Aug 14, 2019

Conversation

kristw
Copy link
Contributor

@kristw kristw commented Aug 13, 2019

🏆 Enhancements

  • Add ChartControlPanelRegistry.
  • Add controlPanel as part of the ChartPlugin.

@kristw kristw requested a review from a team as a code owner August 13, 2019 19:24
@ghost
Copy link

ghost commented Aug 13, 2019

There were the following issues with this Pull Request

  • Commit: 01cdefd
    • ✖ message may not be empty
    • ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.

🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

@kristw kristw changed the title feat: Include control panel configuration in the chart plugin feat: include control panel in the chart plugin Aug 13, 2019
@codecov
Copy link

codecov bot commented Aug 13, 2019 •
edited
Loading

Codecov Report

Merging #203 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #203      +/-   ##
==========================================
+ Coverage   99.91%   99.91%   +<.01%     
==========================================
  Files         101      102       +1     
  Lines        1215     1222       +7     
  Branches      292      293       +1     
==========================================
+ Hits         1214     1221       +7     
  Partials        1        1
Impacted Files Coverage Δ
...ckages/superset-ui-chart/src/models/ChartPlugin.ts 100% <100%> (ø) ⬆️
...c/registries/ChartControlPanelRegistrySingleton.ts 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af877c6...5bfa3dc. Read the comment docs.

@netlify
Copy link

netlify bot commented Aug 13, 2019 •
edited
Loading

Deploy preview for superset-ui ready!

Built with commit 5bfa3dc

https://deploy-preview-203--superset-ui.netlify.com

@ghost
Copy link

ghost commented Aug 13, 2019

There were the following issues with this Pull Request

  • Commit: 01cdefd
    • ✖ message may not be empty
    • ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.

🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

@kristw kristw added the reviewable Ready for review label Aug 13, 2019
isaacpz
isaacpz reviewed Aug 13, 2019
View reviewed changes
Copy link

@isaacpz isaacpz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

williaster
williaster approved these changes Aug 14, 2019
View reviewed changes
Copy link
Contributor

@williaster williaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! LGTM 🚢

@kristw kristw merged commit 920d389 into master Aug 14, 2019
@delete-merged-branch delete-merged-branch bot deleted the kristw--control-panel branch August 14, 2019 17:21
kristw added a commit that referenced this pull request Apr 17, 2020
@kristw
fix: add typings for @storybook/react (#203)
a357487
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@isaacpz isaacpz isaacpz left review comments

@williaster williaster williaster approved these changes

Assignees
No one assigned
Labels
reviewable Ready for review size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kristw @williaster @isaacpz