Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

feat(preset-chart-xy): migrate #377

Merged
merged 12 commits into from
Apr 27, 2020
Merged

feat(preset-chart-xy): migrate #377

merged 12 commits into from
Apr 27, 2020

Conversation

kristw
Copy link
Contributor

@kristw kristw commented Apr 17, 2020

🏆 Enhancements

Migrate preset-chart-xy and word-cloud from plugins repo

@kristw kristw requested a review from a team as a code owner April 17, 2020 23:49
@vercel
Copy link

vercel bot commented Apr 17, 2020 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/superset/superset-ui/noyisxx18
✅ Preview: https://superset-ui-git-kristw-xy.superset.now.sh

@codecov
Copy link

codecov bot commented Apr 17, 2020 •
edited
Loading

Codecov Report

Merging #377 into master will decrease coverage by 1.88%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #377      +/-   ##
==========================================
- Coverage   26.33%   24.45%   -1.89%     
==========================================
  Files         192      235      +43     
  Lines        5293     5733     +440     
  Branches      475      581     +106     
==========================================
+ Hits         1394     1402       +8     
- Misses       3864     4294     +430     
- Partials       35       37       +2
Impacted Files Coverage Δ
plugins/plugin-chart-word-cloud/src/buildQuery.ts 100.00% <ø> (ø)
...ugins/plugin-chart-word-cloud/src/chart/Encoder.ts 0.00% <ø> (ø)
...ns/plugin-chart-word-cloud/src/chart/WordCloud.tsx 0.00% <0.00%> (ø)
plugins/plugin-chart-word-cloud/src/index.ts 0.00% <ø> (ø)
...lugins/plugin-chart-word-cloud/src/legacy/index.ts 0.00% <ø> (ø)
...ugin-chart-word-cloud/src/legacy/transformProps.ts 54.54% <ø> (ø)
...gins/plugin-chart-word-cloud/src/transformProps.ts 0.00% <ø> (ø)
...gins/preset-chart-xy/src/BoxPlot/createMetadata.ts 0.00% <ø> (ø)
plugins/preset-chart-xy/src/BoxPlot/index.ts 0.00% <ø> (ø)
...lugins/preset-chart-xy/src/BoxPlot/legacy/index.ts 0.00% <ø> (ø)
... and 76 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b5e5d2...c51301b. Read the comment docs.

villebro pushed a commit to preset-io/superset-ui that referenced this pull request Apr 18, 2020
@dependabot-preview
build(deps-dev): bump lint-staged from 10.0.7 to 10.0.8 (apache-super…
0e96623 
…set#377)

Bumps [lint-staged](https://github.com/okonet/lint-staged) from 10.0.7 to 10.0.8.
- [Release notes](https://github.com/okonet/lint-staged/releases)
- [Commits](lint-staged/lint-staged@v10.0.7...v10.0.8)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
ktmud
ktmud reviewed Apr 27, 2020
View reviewed changes
package.json
@@ -94,7 +94,7 @@
],
"nimbus": {
"drivers": [
"babel",
{ "driver": "babel", "strategy": "none" },
Copy link
Contributor

@ktmud ktmud Apr 27, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will never know you can do this with nimbus's almost non-existent docs...

ktmud
ktmud reviewed Apr 27, 2020
View reviewed changes
packages/superset-ui-demo/storybook/stories/plugins/plugin-chart-word-cloud/Stories.tsx
new LegacyWordCloudChartPlugin().configure({ key: 'legacy-word-cloud2' }).register();

export default {
title: 'Chart Plugins|plugin-chart-word-cloud',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we change this to "Plugins" so "Core Packages" can always display on the top of the navigation in Storybook:

image

ktmud
ktmud reviewed Apr 27, 2020
View reviewed changes
packages/superset-ui-demo/storybook/stories/plugins/plugin-chart-word-cloud/Stories.tsx
formData={{
colorScheme: 'd3Category10',
metric: 'sum__num',
rotation: select('Rotation', ['square', 'flat', 'random'], 'flat'),
Copy link
Contributor

@ktmud ktmud Apr 27, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The knobs aren't showing up in Storybook. Must add withKnobs decorator to the stories: https://github.com/apache-superset/superset-ui/blob/master/packages/superset-ui-demo/storybook/stories/superset-ui-chart/SuperChartStories.tsx#L17

ktmud
ktmud approved these changes Apr 27, 2020
View reviewed changes
Copy link
Contributor

@ktmud ktmud left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except the knobs are missing. While I did the initial migration, withKnobs are moved to each story from the shared setup script to simplify story imports.

@kristw kristw merged commit fb5370e into master Apr 27, 2020
@delete-merged-branch delete-merged-branch bot deleted the kristw--xy branch April 27, 2020 21:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ktmud ktmud ktmud approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kristw @ktmud