This repository has been archived by the owner on Dec 10, 2021. It is now read-only.
Add support for localization of DataTables #403
Labels
#enhancement
New feature or request
Comments
|
issue-label-bot[bot] commented on Oct 15, 2019, 8:30 AM UTC: Issue-Label Bot is automatically applying the label Links: app homepage, dashboard and code for this bot. |
ghost
mentioned this issue
suddjian
pushed a commit
to suddjian/superset-ui
that referenced
this issue
Apr 29, 2020
… range for trend lines (apache-superset#403) * feat(big-number): add option to align time range In Superset, when a timeseries query has no data at the beginning period or end period of the filtered time range, there will not no data records at those periods, hence the trendline in Big Number chart would not render those periods. This often causes confusion and misinterpretaiton in dashboards, especially for those with multiple trendline charts aligned with each other. They could all be a very smooth line, but actually showing very different time ranges. This PR adds an option "alignTimeRange" to apply the filtered time range on the xAxis. Date periods for empty data will be rendered, but there will be no connected lines, dots, or tooltips for them. It's possible to still show tooltips for those periods, but I decided not to do that as: 1) it makes things much more complicated; 2) I don't want to confuse zero or nulls with empty data. * fix(big-number): disable alignRange by default * refactor(big-number): migrate to Typescript * fix(big-number): typescript build * fix(big-number): change tooltip trigger; fix storybook * fix(big-number): move @types to dependencies * fix(big-number): move all files to ts * build(big-number): add @types/d3-color as dependency * refactor(big-number): remove renderTooltip as prop * feat(big-number): add timeRangeUseFallback options and some refactor * fix(big-number): update formatting functions * fix(big-number): update copy for no data * fix(big-number): address PR feedbacks * feat(big-number): replace timeRangeUseFallback with bigNumberFallback * fix: upgrade @types/react-bootstrap * build(big-number): move react-bootstrap to dependencies * refactor(big-number): more coherent types * feat(big-number): use alert box for fallback values * build(big-number): remove react-bootstrap * build: upgrade nimbus and fix versions Keep running into building errors locally, so upgrade nimbus and fix all related packages to the working latest version. * feat(big-number): adjust fallback warning alignment * build: use a non-fixed version for @types/shortid * build: revert package versions in main
|
The codebase on this repo has been moved to the main Apache Superset repo, and consequently the repo is in the process of being archived. See the Superset Improvement Proposal for details: apache/superset#13013 . While all currently open issues and PRs will be closed, we encourage you to reopen this issue on the main repo if it is still relevant. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
@oskarhinc commented on Oct 15, 2019, 8:30 AM UTC:
Is your feature request related to a problem? Please describe.
DataTable components are not translated - strings are always displayed in English. It could be improved so it's customizable.
Describe the solution you'd like
DataTables support localization, and it's described in the docs. I think we could set the proper language when initializing the table components - here and here. It has to be established how to best detect which language to set - maybe by using localStorage or passing it in parameters of the plugin.
This issue was moved by kristw from apache-superset/superset-ui-plugins#232.
The text was updated successfully, but these errors were encountered: