Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

remove diff hit threshold #6

Closed
williaster opened this issue Sep 18, 2018 · 1 comment
Closed

remove diff hit threshold #6

williaster opened this issue Sep 18, 2018 · 1 comment
Assignees
@williaster
Labels
#code-quality

Comments

@williaster
Copy link
Contributor

Described in #6 here

I will also fix the 90.9% of diff hit issue in another PR. there is still 98.5% coverage after this PR, I think the percentage of the lines changed in a PR is not as relevant and the threshold should be on total coverage %.
@williaster williaster self-assigned this Sep 18, 2018
kristw pushed a commit that referenced this issue Apr 17, 2020
@betodealmeida
fix(legacy-preset-chart-nvd3): redraw markers after legend interaction (
c5df555 
#6)

* fix(legacy-preset-chart-nvd3): redraw markers after legend interaction

* fix: lint
@villebro
Copy link
Contributor

The codebase on this repo has been moved to the main Apache Superset repo, and consequently the repo is in the process of being archived. See the Superset Improvement Proposal for details: apache/superset#13013 . While all currently open issues and PRs will be closed, we encourage you to reopen this issue on the main repo if it is still relevant.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@williaster williaster

Labels
#code-quality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kristw @williaster @villebro