Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

make release script compatible with forks #73

Closed
williaster opened this issue Jan 9, 2019 · 1 comment
Closed

make release script compatible with forks #73

williaster opened this issue Jan 9, 2019 · 1 comment
Labels
#build Development environment #code-quality

Comments

@williaster
Copy link
Contributor

Describe the bug
The current lerna release script was written assuming that the origin branch is the primary apache-superset/superset-ui repo, as opposed to a fork. This is problematic because

  • forks may not be up to date with apache-superset/superset-ui
  • publishing pushes tags and package version number changes to the fork instead of apache-superset/superset-ui, requiring a second PR to update the main repo.

cc @kristw @soboko @xtinec @conglei
@kristw kristw added #code-quality #build Development environment labels Jan 29, 2019
kristw added a commit that referenced this issue Apr 17, 2020
@kristw
feat: integrate line chart with build query and update typings (#73)
9cbbe6e 
* feat: integrate line chart with buildQuery

* fix: typings

* fix: minor

* feat: derive groupbys

* fix: tooltip for single series
@villebro
Copy link
Contributor

The codebase on this repo has been moved to the main Apache Superset repo, and consequently the repo is in the process of being archived. See the Superset Improvement Proposal for details: apache/superset#13013 . While all currently open issues and PRs will be closed, we encourage you to reopen this issue on the main repo if it is still relevant.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
#build Development environment #code-quality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kristw @williaster @villebro