-
Notifications
You must be signed in to change notification settings - Fork 273
fix(plugin-chart-echarts): include label length in distance calculation #1056
fix(plugin-chart-echarts): include label length in distance calculation #1056
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/superset/superset-ui/8WMUXU2bbHmPkodUVaAHBKLPFHTn |
Codecov Report
@@ Coverage Diff @@
## master #1056 +/- ##
==========================================
+ Coverage 27.80% 27.82% +0.02%
==========================================
Files 453 453
Lines 9104 9108 +4
Branches 1416 1417 +1
==========================================
+ Hits 2531 2534 +3
Misses 6381 6381
- Partials 192 193 +1
Continue to review full report at Codecov.
|
@krsnik93 this needs a rebase |
c6b7655
to
a6459e3
Compare
@villebro thanks, done |
@villebro hello, would you have some time to take a look at this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - when there is some spare time let's try to add native support for improved text alignment to the gauge series type in ECharts.
🐛 Bug Fix
Fixes labels overlapping axis as reported here: apache/superset#14072 (comment)
Label length (in chars) is now taken into account when calculating distance from axis.
Screenshots:
![image](https://user-images.githubusercontent.com/13034472/114699278-fd098400-9d17-11eb-9ddc-606884fb289c.png)
![image](https://user-images.githubusercontent.com/13034472/114699303-072b8280-9d18-11eb-945e-b1eddcac4e69.png)
![image](https://user-images.githubusercontent.com/13034472/114699456-3fcb5c00-9d18-11eb-9658-7fa61582c701.png)
![image](https://user-images.githubusercontent.com/13034472/114699487-48bc2d80-9d18-11eb-9d6d-dd3bcb598c51.png)