feat(plugin-chart-echarts): [wip] gauge chart enhancements and fixes #1070

krsnik93 · 2021-04-23T12:23:04Z

🏆 Enhancements

This PR addresses feature requests and bugs raised here: apache/superset#14209

vercel · 2021-04-23T12:23:08Z

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/superset/superset-ui/EGkJ6kzbWtJZCpE9UyXfcwZPzH9t
✅ Preview: https://superset-ui-git-fork-krsnik93-gauge-enhancements-and-8fd53b.vercel.app

codecov · 2021-04-23T14:42:37Z

Codecov Report

Merging #1070 (65cebcc) into master (e675d99) will increase coverage by 0.00%.
The diff coverage is 60.00%.

❗ Current head 65cebcc differs from pull request most recent head 40284a2. Consider uploading reports for the commit 40284a2 to get more accurate results

@@           Coverage Diff           @@
##           master    #1070   +/-   ##
=======================================
  Coverage   28.74%   28.75%           
=======================================
  Files         455      455           
  Lines        9135     9144    +9     
  Branches     1436     1438    +2     
=======================================
+ Hits         2626     2629    +3     
- Misses       6306     6310    +4     
- Partials      203      205    +2

Impacted Files	Coverage Δ
...ns/plugin-chart-echarts/src/Gauge/controlPanel.tsx	`100.00% <ø> (ø)`
plugins/plugin-chart-echarts/src/Gauge/types.ts	`100.00% <ø> (ø)`
...s/plugin-chart-echarts/src/Gauge/transformProps.ts	`76.66% <60.00%> (-7.65%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e675d99...40284a2. Read the comment docs.

junlincc · 2021-05-05T05:24:34Z

@krsnik93 many thanks for the PR! is it ready to turn draft to open?

stephenLYZ · 2021-05-08T06:00:19Z

plugins/plugin-chart-echarts/src/Gauge/transformProps.ts

@@ -127,7 +127,15 @@ export default function transformProps(chartProps: ChartProps) {
      fontSize: FONT_SIZE_MULTIPLIERS.detailFontSize * fontSize,
    },
  }));
-
+  const min = minVal || calculateMin(transformedData);


Should we use ?? to replace || ？I'm not sure if it needs to be recalculated only when minVal is null instead of 0

I was not aware of the ?? operator. Exactly what is needed here. Thanks a lot!

It's ok :). ?? is called Nullish Coalescing which just for the case of null and undefined values. Here, if we use the || operator, it will also be calculated when the value of minVal is 0, which is actually unnecessary.So it may be better to use nullish coalescing.

xiezhongfu · 2021-05-08T14:02:06Z

plugins/plugin-chart-echarts/src/Gauge/transformProps.ts

@@ -70,6 +71,12 @@ const setIntervalBoundsAndColors = (
 const calculateAxisLineWidth = (data: DataRecord[], fontSize: number, overlap: boolean): number =>
  overlap ? fontSize : data.length * fontSize;

+const calculateMin = (data: GaugeDataItemOption[]) =>
+  2 * Math.min(...data.map(d => d.value as number).concat([0]));


Why here must be 2 ?

It does not have to be, I was looking at how other BI tools do this and came up with 2. We could have 1.5, 1.2 or similar. The point is to ensure that the max value fits into the chart, but that there is a bit of additional "space" left on the gauge.

junlincc · 2021-05-11T18:22:00Z

@krsnik93 thanks for addressing the comments. can we have one line description on each commit please 😇

Add a hover tooltip per pointer on gauge chart showing metric names and values

…rt axis Dynamically determine min and max values on the axis from query result unless params explicitly passed through form data

Fix ts errors

villebro · 2021-12-10T07:43:18Z

The codebase on this repo has been moved to the main Apache Superset repo, and consequently the repo is in the process of being archived. See the Superset Improvement Proposal for details: apache/superset#13013 . While all currently open issues and PRs will be closed, we encourage you to reopen this PR on the main repo, which should be as simple as moving over any code changes as follows:

core packages: packages/** (this repo) -> superset-frontend/packages/** (main repo)
plugins: plugins/** (this repo) -> superset-frontend/plugins/** (main repo)

If you need help with the migration, please post a message on the SIP or reach out on the community Slack.

krsnik93 requested a review from a team as a code owner April 23, 2021 12:23

pull-request-size bot added the size/M label Apr 23, 2021

vercel bot had a problem deploying to Preview April 23, 2021 12:23 Failure

krsnik93 marked this pull request as draft April 23, 2021 12:23

krsnik93 force-pushed the gauge-enhancements-and-fixes branch from 1c03268 to 6ca7ec0 Compare April 23, 2021 12:32

vercel bot had a problem deploying to Preview April 23, 2021 12:32 Failure

krsnik93 force-pushed the gauge-enhancements-and-fixes branch from 6ca7ec0 to 45651de Compare April 23, 2021 12:46

vercel bot had a problem deploying to Preview April 23, 2021 12:46 Failure

vercel bot had a problem deploying to Preview April 23, 2021 13:38 Failure

krsnik93 force-pushed the gauge-enhancements-and-fixes branch from 7702f8e to d8e7ab7 Compare April 23, 2021 13:59

vercel bot deployed to Preview April 23, 2021 13:59 View deployment

krsnik93 force-pushed the gauge-enhancements-and-fixes branch from d8e7ab7 to cb41051 Compare April 23, 2021 14:17

vercel bot deployed to Preview April 23, 2021 14:17 View deployment

krsnik93 force-pushed the gauge-enhancements-and-fixes branch from cb41051 to b1feb2c Compare April 23, 2021 14:31

vercel bot deployed to Preview April 23, 2021 14:31 View deployment

krsnik93 marked this pull request as ready for review May 5, 2021 08:07

stephenLYZ reviewed May 8, 2021

View reviewed changes

xiezhongfu reviewed May 8, 2021

View reviewed changes

vercel bot deployed to Preview May 10, 2021 11:48 View deployment

krsnik93 force-pushed the gauge-enhancements-and-fixes branch from 33291ba to 152cefc Compare May 10, 2021 11:55

vercel bot had a problem deploying to Preview May 10, 2021 11:55 Failure

vercel bot had a problem deploying to Preview May 10, 2021 12:02 Failure

vercel bot deployed to Preview May 10, 2021 12:23 View deployment

krsnik93 force-pushed the gauge-enhancements-and-fixes branch from 65cebcc to 465d501 Compare May 12, 2021 08:10

vercel bot deployed to Preview May 12, 2021 08:10 View deployment

style(plugin-chart-echarts): add pointer tooltip to gauge chart

32eb555

Add a hover tooltip per pointer on gauge chart showing metric names and values

root added 2 commits May 12, 2021 09:31

fix(plugin-chart-echarts): dynamically determine min/max on gauge cha…

1888a50

…rt axis Dynamically determine min and max values on the axis from query result unless params explicitly passed through form data

fix lint

40284a2

Fix ts errors

krsnik93 force-pushed the gauge-enhancements-and-fixes branch from 465d501 to 40284a2 Compare May 12, 2021 08:32

vercel bot deployed to Preview May 12, 2021 08:33 View deployment

stephenLYZ mentioned this pull request Aug 17, 2021

[Gauge]Cross Filtering for Gauge Chart Issue (Filter Icon not appearing on other charts) apache/superset#16255

Closed

villebro closed this Dec 10, 2021

stephenLYZ mentioned this pull request Aug 7, 2022

fix(plugin-chart-echarts): gauge chart enhancements and fixes apache/superset#21007

Merged

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(plugin-chart-echarts): [wip] gauge chart enhancements and fixes #1070

feat(plugin-chart-echarts): [wip] gauge chart enhancements and fixes #1070

krsnik93 commented Apr 23, 2021

vercel bot commented Apr 23, 2021 •

edited

codecov bot commented Apr 23, 2021 •

edited

junlincc commented May 5, 2021 •

edited

stephenLYZ May 8, 2021

krsnik93 May 10, 2021

stephenLYZ May 10, 2021

xiezhongfu May 8, 2021

krsnik93 May 10, 2021

junlincc commented May 11, 2021

villebro commented Dec 10, 2021

feat(plugin-chart-echarts): [wip] gauge chart enhancements and fixes #1070

feat(plugin-chart-echarts): [wip] gauge chart enhancements and fixes #1070

Conversation

krsnik93 commented Apr 23, 2021

vercel bot commented Apr 23, 2021 • edited

codecov bot commented Apr 23, 2021 • edited

Codecov Report

junlincc commented May 5, 2021 • edited

stephenLYZ May 8, 2021

Choose a reason for hiding this comment

krsnik93 May 10, 2021

Choose a reason for hiding this comment

stephenLYZ May 10, 2021

Choose a reason for hiding this comment

xiezhongfu May 8, 2021

Choose a reason for hiding this comment

krsnik93 May 10, 2021

Choose a reason for hiding this comment

junlincc commented May 11, 2021

villebro commented Dec 10, 2021

vercel bot commented Apr 23, 2021 •

edited

codecov bot commented Apr 23, 2021 •

edited

junlincc commented May 5, 2021 •

edited