Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

fix: adjusts ControlHeader tooltip layout, exports ControlHeader #1107

Conversation

rusackas
Copy link
Member

💔 Breaking Changes

🏆 Enhancements

📜 Documentation

🐛 Bug Fix

Adds similar layout tweaks to apache/superset#14529
This time, over on the twin component in Superset UI.

This also exports this updated component, so that we can use it everywhere in Superset, and delete the twin over in that repo.

tenor

🏠 Internal

@rusackas rusackas requested a review from a team as a code owner May 13, 2021 06:28
@vercel
Copy link

vercel bot commented May 13, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/superset/superset-ui/6ga8oLBsC1c6bzTu5ormnJDgYHiQ
✅ Preview: https://superset-ui-git-fork-preset-io-controlheader-label-to-7eb99f.vercel.app

@codecov
Copy link

codecov bot commented May 13, 2021

Codecov Report

Merging #1107 (0d7f011) into master (7da2a9d) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1107      +/-   ##
==========================================
- Coverage   28.98%   28.98%   -0.01%     
==========================================
  Files         462      462              
  Lines        9200     9201       +1     
  Branches     1449     1449              
==========================================
  Hits         2667     2667              
- Misses       6331     6332       +1     
  Partials      202      202              
Impacted Files Coverage Δ
...ui-chart-controls/src/components/ControlHeader.tsx 0.00% <0.00%> (ø)
packages/superset-ui-chart-controls/src/index.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7da2a9d...0d7f011. Read the comment docs.

@rusackas rusackas requested a review from kgabryje May 14, 2021 05:56
@@ -1,3 +1,4 @@
/** @jsx jsx */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does that work? What's the benefit of using /** @jsx jsx */ instead of importing React?

@@ -57,7 +58,16 @@ export default function ControlHeader({
const renderOptionalIcons = () => {
if (hovered) {
return (
<span>
<span
css={(theme: any) => css`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
css={(theme: any) => css`
css={(theme: SupersetTheme) => css`

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is using css attribute preferable to creating a separate styled.span? I'm asking for future reference 🙂

@villebro
Copy link
Contributor

The codebase on this repo has been moved to the main Apache Superset repo, and consequently the repo is in the process of being archived. See the Superset Improvement Proposal for details: apache/superset#13013 . While all currently open issues and PRs will be closed, we encourage you to reopen this PR on the main repo, which should be as simple as moving over any code changes as follows:

  • core packages: packages/** (this repo) -> superset-frontend/packages/** (main repo)
  • plugins: plugins/** (this repo) -> superset-frontend/plugins/** (main repo)

If you need help with the migration, please post a message on the SIP or reach out on the community Slack.

@villebro villebro closed this Dec 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants