fix: adjusts ControlHeader tooltip layout, exports ControlHeader #1107
fix: adjusts ControlHeader tooltip layout, exports ControlHeader #1107
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/superset/superset-ui/6ga8oLBsC1c6bzTu5ormnJDgYHiQ |
Codecov Report
@@ Coverage Diff @@
## master #1107 +/- ##
==========================================
- Coverage 28.98% 28.98% -0.01%
==========================================
Files 462 462
Lines 9200 9201 +1
Branches 1449 1449
==========================================
Hits 2667 2667
- Misses 6331 6332 +1
Partials 202 202
Continue to review full report at Codecov.
|
@@ -1,3 +1,4 @@ | |||
/** @jsx jsx */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How does that work? What's the benefit of using /** @jsx jsx */
instead of importing React?
@@ -57,7 +58,16 @@ export default function ControlHeader({ | |||
const renderOptionalIcons = () => { | |||
if (hovered) { | |||
return ( | |||
<span> | |||
<span | |||
css={(theme: any) => css` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
css={(theme: any) => css` | |
css={(theme: SupersetTheme) => css` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is using css
attribute preferable to creating a separate styled.span
? I'm asking for future reference 🙂
The codebase on this repo has been moved to the main Apache Superset repo, and consequently the repo is in the process of being archived. See the Superset Improvement Proposal for details: apache/superset#13013 . While all currently open issues and PRs will be closed, we encourage you to reopen this PR on the main repo, which should be as simple as moving over any code changes as follows:
If you need help with the migration, please post a message on the SIP or reach out on the community Slack. |
💔 Breaking Changes
🏆 Enhancements
📜 Documentation
🐛 Bug Fix
Adds similar layout tweaks to apache/superset#14529
This time, over on the twin component in Superset UI.
This also exports this updated component, so that we can use it everywhere in Superset, and delete the twin over in that repo.
🏠 Internal