Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

fix(plugin-chart-echarts): disabling dragging the treemap on the dashboard #1109

Merged
merged 11 commits into from
May 15, 2021

Conversation

stephenLYZ
Copy link
Contributor

🐛 Bug Fix

  1. fix the storybook
  2. disabling dragging the treemap on the dashboard

before

treemap.mp4

after

2021-05-14.8.46.39.mov

@stephenLYZ stephenLYZ requested a review from a team as a code owner May 14, 2021 12:47
@vercel
Copy link

vercel bot commented May 14, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/superset/superset-ui/EaqJajJe6J9ZbrqvCbZyWBy9rMeA
✅ Preview: https://superset-ui-git-fork-stephenlyz-fix-treemap-superset.vercel.app

@codecov
Copy link

codecov bot commented May 14, 2021

Codecov Report

Merging #1109 (a7987c9) into master (7da2a9d) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1109      +/-   ##
==========================================
- Coverage   28.98%   28.98%   -0.01%     
==========================================
  Files         462      462              
  Lines        9200     9201       +1     
  Branches     1449     1450       +1     
==========================================
  Hits         2667     2667              
  Misses       6331     6331              
- Partials      202      203       +1     
Impacted Files Coverage Δ
...plugin-chart-echarts/src/Treemap/transformProps.ts 52.00% <0.00%> (-1.07%) ⬇️
plugins/plugin-chart-echarts/src/Treemap/types.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7da2a9d...a7987c9. Read the comment docs.

Copy link
Contributor

@zhaoyongjie zhaoyongjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for disabling drag Treemap on the Dashboard.
LGTM this code changes. Thanks for this improvement.

CC @junlincc

@zhaoyongjie zhaoyongjie merged commit e92ea0d into apache-superset:master May 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants