Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

chore(core): add ENABLE_DND_WITH_CLICK_UX ff #1297

Merged
merged 1 commit into from
Aug 10, 2021

Conversation

kgabryje
Copy link
Contributor

Add ENABLE_DND_WITH_CLICK_UX in order to hide features introduced in apache/superset#16119 behind a feature flag

@kgabryje kgabryje requested a review from villebro August 10, 2021 12:03
@kgabryje kgabryje requested a review from a team as a code owner August 10, 2021 12:03
@vercel
Copy link

vercel bot commented Aug 10, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/superset/superset-ui/2kczEBjzsNEJPiqTddfdYRLF7wKv
✅ Preview: https://superset-ui-git-fork-kgabryje-chore-add-ff-dnd-click-superset.vercel.app

Copy link
Contributor

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although I personally prefer to make this part of the regular dnd feature

@codecov
Copy link

codecov bot commented Aug 10, 2021

Codecov Report

Merging #1297 (aeef568) into master (7a76537) will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1297      +/-   ##
==========================================
- Coverage   30.04%   29.98%   -0.06%     
==========================================
  Files         485      485              
  Lines        9753     9805      +52     
  Branches     1620     1639      +19     
==========================================
+ Hits         2930     2940      +10     
- Misses       6596     6633      +37     
- Partials      227      232       +5     
Impacted Files Coverage Δ
...ackages/superset-ui-core/src/utils/featureFlags.ts 100.00% <ø> (ø)
...lugin-chart-echarts/src/Timeseries/transformers.ts 44.89% <0.00%> (-9.54%) ⬇️
...gin-chart-echarts/src/Timeseries/transformProps.ts 46.37% <0.00%> (-9.18%) ⬇️
...ugins/plugin-chart-echarts/src/Timeseries/types.ts 100.00% <0.00%> (ø)
...s/legacy-plugin-chart-country-map/src/countries.ts 0.00% <0.00%> (ø)
...s/plugin-chart-echarts/src/Radar/transformProps.ts 0.00% <0.00%> (ø)
.../legacy-plugin-chart-sankey-loop/src/SankeyLoop.js 0.00% <0.00%> (ø)
...ugin-chart-echarts/src/Timeseries/controlPanel.tsx 40.00% <0.00%> (ø)
...erset-ui-chart-controls/src/components/Tooltip.tsx 20.00% <0.00%> (ø)
...chart-echarts/src/Timeseries/Area/controlPanel.tsx 50.00% <0.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a76537...aeef568. Read the comment docs.

@kgabryje kgabryje merged commit fb8e11a into apache-superset:master Aug 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants