Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

feat: Set default for Accept field in header to take application/json #1413

Merged
merged 5 commits into from
Nov 8, 2021

Conversation

hughhhh
Copy link
Contributor

@hughhhh hughhhh commented Oct 19, 2021

💔 Breaking Changes:

Related to apache/superset#17195, Users would see html render for error instead of error json response. To make sure this doesn't happen we are setting the default headers to Accept: application/json

Screen Shot 2021-10-26 at 1 48 46 PM

🏆 Enhancements

📜 Documentation

🐛 Bug Fix

🏠 Internal

@hughhhh hughhhh requested a review from a team as a code owner October 19, 2021 21:37
@vercel
Copy link

vercel bot commented Oct 19, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/superset/superset-ui/CWdgn68K7y2Kcz5NUUKNstKm7zeY
✅ Preview: https://superset-ui-git-default-content-type-superset.vercel.app

@hughhhh hughhhh changed the title Set default for Content-Type feat: Set default for Accept field in header to take application/json Oct 19, 2021
@codecov
Copy link

codecov bot commented Oct 19, 2021

Codecov Report

Merging #1413 (4ee5c88) into master (f279549) will increase coverage by 3.25%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1413      +/-   ##
==========================================
+ Coverage   30.42%   33.67%   +3.25%     
==========================================
  Files         497      499       +2     
  Lines       10003    12481    +2478     
  Branches     1689     2241     +552     
==========================================
+ Hits         3043     4203    +1160     
- Misses       6714     8015    +1301     
- Partials      246      263      +17     
Impacted Files Coverage Δ
...rset-ui-core/src/connection/SupersetClientClass.ts 100.00% <100.00%> (ø)
...chart-echarts/src/Timeseries/Area/controlPanel.tsx 42.85% <0.00%> (-7.15%) ⬇️
...rt-echarts/src/Timeseries/Regular/controlPanel.tsx 42.85% <0.00%> (-7.15%) ⬇️
...ts/src/Timeseries/Regular/Scatter/controlPanel.tsx 42.85% <0.00%> (-7.15%) ⬇️
...ugin-chart-echarts/src/Timeseries/controlPanel.tsx 33.33% <0.00%> (-6.67%) ⬇️
...chart-echarts/src/Timeseries/Step/controlPanel.tsx 33.33% <0.00%> (-6.67%) ⬇️
plugins/plugin-chart-table/src/i18n.ts 100.00% <0.00%> (ø)
plugins/plugin-chart-table/src/Styles.tsx 100.00% <0.00%> (ø)
plugins/preset-chart-xy/src/Line/index.ts 0.00% <0.00%> (ø)
packages/superset-ui-core/src/color/index.ts 100.00% <0.00%> (ø)
... and 168 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f279549...4ee5c88. Read the comment docs.

Copy link
Contributor

@betodealmeida betodealmeida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the test!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants