-
Notifications
You must be signed in to change notification settings - Fork 272
fix: revert default series limit and update eligible choices #1430
fix: revert default series limit and update eligible choices #1430
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/superset/superset-ui/chL5Fk5MWQByT84S6d3sx64yBHCq |
@@ -330,7 +330,6 @@ const limit: SharedControlConfig<'SelectControl'> = { | |||
freeForm: true, | |||
label: t('Series limit'), | |||
validators: [legacyValidateInteger], | |||
default: 100, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with removing the default, as the added overhead of the limit query is difficult to justify nowadays. Should we also add clearable: true
here to make sure the value is clearable, as the "unset" does not exist in the SERIES_LIMIT
constant?
Codecov Report
@@ Coverage Diff @@
## master #1430 +/- ##
=======================================
Coverage 30.42% 30.42%
=======================================
Files 497 497
Lines 10003 10003
Branches 1689 1689
=======================================
Hits 3043 3043
Misses 6714 6714
Partials 246 246
Continue to review full report at Codecov.
|
This reverts commit 5bd2a14.
d80c839
to
1c1bcf1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
🏠 Internal
This PR is one of a slew to the apache/superset and apache-superset/superset-ui repos to revert pseudo recent changes to the series restrictions for high cardinality groupings. For more context please refer to this Slack thread in the #committers channel.
Specifically this PR reverts #1033 (and more) to ensure there is no default if undefined given that:
Select ...
is rendered, that a default is set.0
which is misleading (and thus removed as an option) given that in actually it is akin to having no limits as the joined subquery logic is not invoked.Furthermore said change was actually a breaking change but was not protected with a feature flag.
Related PRs: