fix: revert default series limit and update eligible choices

[john-bodley]

🏠 Internal

This PR is one of a slew to the apache/superset and apache-superset/superset-ui repos to revert pseudo recent changes to the series restrictions for high cardinality groupings. For more context please refer to this Slack thread in the #committers channel.

Specifically this PR reverts #1033 (and more) to ensure there is no default if undefined given that:

• It is not apparent from the UX when the current default is cleared, i.e., Select ... is rendered, that a default is set.
• The only way to previously disable the joined subquery is to set the series limit to 0 which is misleading (and thus removed as an option) given that in actually it is akin to having no limits as the joined subquery logic is not invoked.

Furthermore said change was actually a breaking change but was not protected with a feature flag.

Related PRs:

• fix: revert default series sort-by metric apache/superset#17236
• fix: update chart sorting control labels/descriptions #1436

[vercel]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/superset/superset-ui/chL5Fk5MWQByT84S6d3sx64yBHCq
✅ Preview: https://superset-ui-git-revert-1033-etr2460-default-ser-121fb0-superset.vercel.app

[villebro]

I agree with removing the default, as the added overhead of the limit query is difficult to justify nowadays. Should we also add clearable: true here to make sure the value is clearable, as the "unset" does not exist in the SERIES_LIMIT constant?

[codecov]

Codecov Report

Merging #1430 (1c1bcf1) into master (f279549) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1430   +/-   ##
=======================================
  Coverage   30.42%   30.42%           
=======================================
  Files         497      497           
  Lines       10003    10003           
  Branches     1689     1689           
=======================================
  Hits         3043     3043           
  Misses       6714     6714           
  Partials      246      246           

Impacted Files	Coverage Δ
...et-ui-chart-controls/src/shared-controls/index.tsx	36.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f279549...1c1bcf1. Read the comment docs.

[villebro]

LGTM