Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

build: start merging superset-ui-plugins #333

Merged
merged 1 commit into from
Apr 2, 2020
Merged

build: start merging superset-ui-plugins #333

merged 1 commit into from
Apr 2, 2020

Conversation

ktmud
Copy link
Contributor

@ktmud ktmud commented Apr 2, 2020

🏆 Enhancements

See #326 #331 #332 . Merging superset-ui-plugins and superset-ui to the same monorepo simplifies the building configs and makes cross package work easier.

This PR merges the feature branch to master. I have migrated the two basic plugins I recently worked on (BigNumber and Table). Other plugins will follow.

@ktmud ktmud requested a review from a team as a code owner April 2, 2020 01:33
@vercel
Copy link

vercel bot commented Apr 2, 2020

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/superset/superset-ui/7l8m0yhkm
✅ Preview: https://superset-ui-git-merge-plugins.superset.now.sh

@codecov
Copy link

codecov bot commented Apr 2, 2020

Codecov Report

Merging #333 into master will decrease coverage by 7.98%.
The diff coverage is 51.83%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #333      +/-   ##
==========================================
- Coverage     100%   92.01%   -7.99%     
==========================================
  Files         108      118      +10     
  Lines        1248     1478     +230     
  Branches      310      378      +68     
==========================================
+ Hits         1248     1360     +112     
- Misses          0       89      +89     
- Partials        0       29      +29
Impacted Files Coverage Δ
.../superset-ui-core/src/models/ExtensibleFunction.ts 100% <ø> (ø) ⬆️
plugins/big-number/src/BigNumberTotal/index.ts 0% <0%> (ø)
plugins/table/src/index.ts 0% <0%> (ø)
plugins/big-number/src/BigNumber/index.ts 0% <0%> (ø)
plugins/big-number/src/BigNumber/BigNumber.tsx 0% <0%> (ø)
plugins/big-number/src/preset.ts 0% <0%> (ø)
packages/superset-ui-color/src/SequentialScheme.ts 100% <100%> (ø) ⬆️
...format/src/factories/createSmartNumberFormatter.ts 100% <100%> (ø) ⬆️
...superset-ui-color/src/CategoricalColorNamespace.ts 100% <100%> (ø) ⬆️
plugins/table/test/testData.ts 100% <100%> (ø)
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27f7df6...94f6d01. Read the comment docs.

@netlify
Copy link

netlify bot commented Apr 2, 2020

Deploy preview for superset-ui ready!

Built with commit 94f6d01

https://deploy-preview-333--superset-ui.netlify.com

@ktmud ktmud merged commit 47f2265 into master Apr 2, 2020
@delete-merged-branch delete-merged-branch bot deleted the merge-plugins branch April 2, 2020 01:53
ktmud added a commit to ktmud/superset-ui-plugins that referenced this pull request Apr 3, 2020
ktmud added a commit to ktmud/superset-ui-plugins that referenced this pull request Apr 3, 2020
kristw pushed a commit to apache-superset/superset-ui-plugins that referenced this pull request Apr 3, 2020
kristw pushed a commit that referenced this pull request Apr 17, 2020
Bumps [@vx/group](https://github.com/hshoff/vx) from 0.0.192 to 0.0.193.
- [Release notes](https://github.com/hshoff/vx/releases)
- [Changelog](https://github.com/hshoff/vx/blob/master/CHANGELOG.md)
- [Commits](airbnb/visx@v0.0.192...v0.0.193)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
kristw pushed a commit that referenced this pull request Apr 17, 2020
They are moved to superset-ui by #333
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 17, 2021
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 24, 2021
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 25, 2021
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant