fix: lint errors

[kristw]

🐛 Bug Fix

• Resolve type warnings from eslint
• Reduced from 274 errors to 198 errors

[vercel]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/superset/superset-ui/auacwd1qo
✅ Preview: https://superset-ui-git-kristw-fix-lint.superset.now.sh

[codecov]

Codecov Report

Merging #420 into master will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #420   +/-   ##
=======================================
  Coverage   22.28%   22.28%           
=======================================
  Files         261      261           
  Lines        6474     6474           
  Branches      587      587           
=======================================
  Hits         1443     1443           
  Misses       4994     4994           
  Partials       37       37           

Impacted Files	Coverage Δ
...s/superset-ui-chart-composition/src/ChartFrame.tsx	100.00% <ø> (ø)
...es/superset-ui-chart/src/components/SuperChart.tsx	100.00% <ø> (ø)
...-ui-chart/src/components/createLoadableRenderer.ts	100.00% <ø> (ø)
...superset-ui-connection/test/utils/throwIfCalled.ts	100.00% <ø> (ø)
packages/superset-ui-core/src/models/Plugin.ts	100.00% <ø> (ø)
packages/superset-ui-core/src/utils/isDefined.ts	100.00% <ø> (ø)
...ckages/superset-ui-core/src/utils/makeSingleton.ts	100.00% <ø> (ø)
plugins/legacy-plugin-chart-heatmap/src/Heatmap.js	0.00% <ø> (ø)
...ins/legacy-plugin-chart-horizon/src/HorizonRow.jsx	0.00% <ø> (ø)
...lugin-chart-map-box/src/ScatterPlotGlowOverlay.jsx	0.00% <ø> (ø)
... and 15 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f72e2d6...daa0d4c. Read the comment docs.

[rusackas]

@kristw LGTM, but wondered if you checked to see if any any of the remaining // eslint-disable-next-line @typescript-eslint/no-explicit-any lines could be removed by changing any types to unknown

[kristw]

@rusackas The one I'm disabling here broke when it is changed to unknown. I'm not sure how best to define the plain object type { [key: string]: any } that won't break. If you have suggestion, please let me know.

[rusackas]

@rusackas The one I'm disabling here broke when it is changed to unknown. I'm not sure how best to define the plain object type { [key: string]: any } that won't break. If you have suggestion, please let me know.

Ok, I figured you tried it, but thought I should ask :P I don't have any better suggestions, sadly.