Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

chore: pulling in Sunburst controls from incubator-superset #443

Merged

Conversation

rusackas
Copy link
Member

@rusackas rusackas commented May 6, 2020

💔 Breaking Changes

🏆 Enhancements

This pulls in the controls from incubator-superset, and bumps the version number of the package. Another PR has been filed on incubator-superset to pull in this new package and remove the old controls and shims.

📜 Documentation

🐛 Bug Fix

🏠 Internal

@rusackas rusackas requested a review from a team as a code owner May 6, 2020 06:18
@vercel
Copy link

vercel bot commented May 6, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/superset/superset-ui/5443npzl7
✅ Preview: https://superset-ui-git-fork-preset-io-sunburst-controls-migration.superset.now.sh

@rusackas rusackas changed the title chore: pulling in controls from incubator-superset chore: pulling in Sunburst controls from incubator-superset May 6, 2020
@codecov
Copy link

codecov bot commented May 6, 2020

Codecov Report

Merging #443 into master will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #443      +/-   ##
==========================================
+ Coverage   22.20%   22.25%   +0.05%     
==========================================
  Files         264      265       +1     
  Lines        6500     6521      +21     
  Branches      588      591       +3     
==========================================
+ Hits         1443     1451       +8     
- Misses       5020     5033      +13     
  Partials       37       37              
Impacted Files Coverage Δ
plugins/legacy-plugin-chart-sunburst/src/index.js 0.00% <ø> (ø)
plugins/legacy-preset-chart-nvd3/src/NVD3Vis.js 0.00% <0.00%> (ø)
plugins/legacy-plugin-chart-world-map/src/index.js 0.00% <0.00%> (ø)
...ackages/superset-ui-query/src/buildQueryContext.ts 100.00% <0.00%> (ø)
...kages/superset-ui-query/src/types/QueryFormData.ts 100.00% <0.00%> (ø)
...ins/legacy-preset-chart-nvd3/src/transformProps.js 0.00% <0.00%> (ø)
...ins/legacy-preset-chart-nvd3/src/utils/isTruthy.js 100.00% <0.00%> (ø)
...ins/legacy-preset-chart-nvd3/src/utils/tokenize.ts 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86847d1...fad0d89. Read the comment docs.

@rusackas rusackas requested a review from kristw May 6, 2020 15:46
@kristw kristw merged commit a8a9e9c into apache-superset:master May 6, 2020
@rusackas rusackas deleted the sunburst-controls-migration branch May 6, 2020 20:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants