Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

fix: Remove .ts suffix from NVD3 imports #453

Merged
merged 3 commits into from
May 7, 2020

Conversation

villebro
Copy link
Contributor

@villebro villebro commented May 7, 2020

🐛 Bug Fix

The current released version of NVD3 viz' doesn't work due to the import referencing the ts files (the linter forced me to add the suffix). I'm not really sure we should have that check here, as it appears to be causing broken releases.

@kristw @rusackas @ktmud

@villebro villebro requested a review from a team as a code owner May 7, 2020 10:56
@vercel
Copy link

vercel bot commented May 7, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/superset/superset-ui/4u37bbt5c
✅ Preview: https://superset-ui-git-fork-preset-io-villebro-ts-import.superset.now.sh

@codecov
Copy link

codecov bot commented May 7, 2020

Codecov Report

Merging #453 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #453   +/-   ##
======================================
  Coverage    3.20%   3.20%           
======================================
  Files         152     152           
  Lines        5238    5238           
  Branches      275     275           
======================================
  Hits          168     168           
  Misses       5033    5033           
  Partials       37      37           
Impacted Files Coverage Δ
...ins/legacy-preset-chart-nvd3/src/transformProps.js 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af8722d...1f3e7a8. Read the comment docs.

@rusackas rusackas merged commit b80372d into apache-superset:master May 7, 2020
@rusackas rusackas deleted the villebro/ts-import branch May 7, 2020 16:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants