This repository has been archived by the owner on Dec 10, 2021. It is now read-only.
fix(plugin-chart-table): anchor should keep href #661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/superset/superset-ui/im9z39pds |
ktmud
commented
Jul 1, 2020
| span: ['style', 'class', 'title'], | ||
| div: ['style', 'class'], | ||
| a: ['style', 'class', 'href', 'title', 'target'], | ||
| img: ['style', 'class', 'src', 'alt', 'title', 'width', 'height'], |
There was a problem hiding this comment.
Let's also allow CSS classnames.
Codecov Report
@@ Coverage Diff @@
## master #661 +/- ##
=======================================
Coverage 24.18% 24.18%
=======================================
Files 330 330
Lines 7491 7491
Branches 895 895
=======================================
Hits 1812 1812
Misses 5592 5592
Partials 87 87
Continue to review full report at Codecov.
|
kristw
approved these changes
Jul 1, 2020
6 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐛 Bug Fix
Re-enable table chart to create anchor element with link.
Test Plan
Storybook