Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

refactor: move superset-ui/chart-composition to core #759

Merged

Conversation

ktmud
Copy link
Contributor

@ktmud ktmud commented Aug 27, 2020

💔 Breaking Changes

🏆 Enhancements

Related: #728 #729 #730 #732 #755 #756 #757

@ktmud ktmud requested a review from a team as a code owner August 27, 2020 19:38
@vercel
Copy link

vercel bot commented Aug 27, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/superset/superset-ui/5yap526tg
✅ Preview: https://superset-ui-git-fork-ktmud-monopackage-move-chart-composition.superset.vercel.app

@codecov
Copy link

codecov bot commented Aug 27, 2020

Codecov Report

Merging #759 into monopackage will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           monopackage     #759   +/-   ##
============================================
  Coverage        24.32%   24.32%           
============================================
  Files              339      339           
  Lines             7700     7700           
  Branches           956      956           
============================================
  Hits              1873     1873           
  Misses            5753     5753           
  Partials            74       74           
Impacted Files Coverage Δ
...erset-ui-core/src/chart-composition/ChartFrame.tsx 100.00% <ø> (ø)
...i-core/src/chart-composition/legend/WithLegend.tsx 100.00% <ø> (ø)
...ore/src/chart-composition/tooltip/TooltipFrame.tsx 100.00% <ø> (ø)
...ore/src/chart-composition/tooltip/TooltipTable.tsx 100.00% <ø> (ø)
...ugin-chart-choropleth-map/src/chart/MapTooltip.tsx 0.00% <ø> (ø)
...preset-chart-xy/src/components/BoxPlot/BoxPlot.tsx 0.00% <ø> (ø)
.../src/components/BoxPlot/DefaultTooltipRenderer.tsx 0.00% <ø> (ø)
...-xy/src/components/Line/DefaultTooltipRenderer.tsx 0.00% <ø> (ø)
...ugins/preset-chart-xy/src/components/Line/Line.tsx 0.00% <ø> (ø)
.../components/ScatterPlot/DefaultTooltipRenderer.tsx 0.00% <ø> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1bdcd9d...28b1daf. Read the comment docs.

@ktmud ktmud merged commit 21bd057 into apache-superset:monopackage Aug 27, 2020
ktmud added a commit that referenced this pull request Sep 2, 2020
1. move translation, connection, query to core (#729)
2. update encodable to remove formatter inter-dependency (#744)
3. move number-format and time-format to core (#730)
4. move superset-ui/dimension to core (#732)
5. move superset-ui/color to core (#755)
6. move superset-ui/style to core (#756)
7. move superset-ui/validator to core (#757)
8: move superset-ui/chart-composition to core (#759)
ktmud added a commit that referenced this pull request Sep 2, 2020
1. move translation, connection, query to core (#729)
2. update encodable to remove formatter inter-dependency (#744)
3. move number-format and time-format to core (#730)
4. move superset-ui/dimension to core (#732)
5. move superset-ui/color to core (#755)
6. move superset-ui/style to core (#756)
7. move superset-ui/validator to core (#757)
8: move superset-ui/chart-composition to core (#759)
ktmud added a commit that referenced this pull request Sep 3, 2020
1. move translation, connection, query to core (#729)
2. update encodable to remove formatter inter-dependency (#744)
3. move number-format and time-format to core (#730)
4. move superset-ui/dimension to core (#732)
5. move superset-ui/color to core (#755)
6. move superset-ui/style to core (#756)
7. move superset-ui/validator to core (#757)
8: move superset-ui/chart-composition to core (#759)
9: move superset-ui/chart to core (#760)
ktmud added a commit that referenced this pull request Sep 3, 2020
1. move translation, connection, query to core (#729)
2. update encodable to remove formatter inter-dependency (#744)
3. move number-format and time-format to core (#730)
4. move superset-ui/dimension to core (#732)
5. move superset-ui/color to core (#755)
6. move superset-ui/style to core (#756)
7. move superset-ui/validator to core (#757)
8. move superset-ui/chart-composition to core (#759)
9. move superset-ui/chart to core (#760)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants