feat(plugin-chart-echarts): add graph echart #918

mayurnewase · 2021-01-27T06:31:36Z

🏆 Enhancements
Migrated legacy force directed chart to echart

Todos

Screenshots
1.Circular type

2.Force type

remaining: expose those in control panel make them all work add tests

vercel · 2021-01-27T06:31:41Z

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/superset/superset-ui-mcn5lxgmc/superset
✅ Preview: https://superset-ui-git-fork-mayurnewase-echart-force-directed.superset.vercel.app

mayurnewase · 2021-01-27T06:36:24Z

@villebro

villebro · 2021-01-27T07:02:29Z

This is wonderful @mayurnewase !!!!! 🎉 Really looking forward to testing + reviewing!

mayurnewase · 2021-01-31T03:15:32Z

@villebro Should we seperate groupby field into source and target?

junlincc · 2021-01-31T04:35:43Z

@villebro Should we seperate groupby field like source and target?

Yes, please do. This has caused major confusion. @mayurnewase

villebro · 2021-01-31T11:13:22Z

@mayurnewase yes, I'm not sure why it's been designed that way, but having separate single selects for source and target makes much more sense 👍

ktmud

Thanks for the contribution. Adding a couple of comments on code style and typing.

+1 on separating source and target control.

plugins/plugin-chart-echarts/src/Pie/transformProps.ts

plugins/plugin-chart-echarts/src/index.ts

plugins/plugin-chart-echarts/src/Graph/transformProps.ts

plugins/plugin-chart-echarts/src/Graph/index.ts

plugins/plugin-chart-echarts/src/Graph/controlPanel.tsx

plugins/plugin-chart-echarts/src/Graph/types.ts

plugins/plugin-chart-echarts/src/Graph/EchartsGraph.tsx

rusackas · 2021-02-02T07:08:00Z

Very excited about this!

One small detail before this gets merged is to update the thumbnail to include a pic of the force graph itself :)

villebro

This is super nice! 🎉 One last recommendation for reducing default zoom level, other than that this seems good to go after the linting errors are fixed!

villebro · 2021-02-17T11:19:13Z

plugins/plugin-chart-echarts/src/Graph/constants.ts

+import { GraphSeriesOption } from 'echarts';
+
+export const DEFAULT_GRAPH_SERIES_OPTION: GraphSeriesOption = {
+  zoom: 1,


I noticed that this might be better at something lower; see the 0.7 (upper) vs the current default of 1.0 (lower). This applies especially to circular mode, but it appears to also be over-zoomed on force mode.

villebro · 2021-02-17T11:22:54Z

plugins/plugin-chart-echarts/src/Graph/controlPanel.tsx

+        [<h1 className="section-header">{t('Legend')}</h1>],
+        [showLegendControl],
+        [legendTypeControl, legendOrientationControl],
+        [legendMarginControl, noopControl],


Yes, it appears to be unrelated to this PR, so better save for another PR

…cted

ktmud · 2021-02-17T21:35:09Z

@mayurnewase I did some further optimization and pushed directly to your branch. Hope you don't mind.

Here's a summary of the changes:

Refactored the loops and added normalized edges
Added separate controls for source node category and target node category.
Merged setLabelVisibility and setNormalizedSymbolSize to one loop
Fixed a bycatch JS error related to changing datasets.
Adjusted the default zoom level as @villebro suggested

ktmud · 2021-02-17T21:41:59Z

packages/superset-ui-core/src/query/types/QueryFormData.ts

@@ -124,8 +124,8 @@ export interface BaseFormData extends TimeRange, FormDataResidual {
  groupby?: QueryFormColumn[];
  all_columns?: QueryFormColumn[];
  /** list of filters */
-  adhoc_filters?: AdhocFilter[];
-  extra_filters?: QueryFormExtraFilter[];
+  adhoc_filters?: AdhocFilter[] | null;


adhoc_filters may be null when switching datasets, causing this JS error if you hit Cmd + Enter after switching to a new dataset:

plugins/plugin-chart-echarts/src/Graph/transformProps.ts

ktmud · 2021-02-19T19:06:25Z

Looking good! @mayurnewase Thanks for all the iterations!

Merging to keep your sanity! 😄

mayurnewase added 3 commits January 25, 2021 01:16

barebone plugin

cf96c63

added configuration nobs

d2d9c89

remaining: expose those in control panel make them all work add tests

Configuration complete

04a9b00

mayurnewase requested a review from a team as a code owner January 27, 2021 06:31

vercel bot deployed to Preview January 27, 2021 06:31 View deployment

mayurnewase changed the title ~~Echart force directed~~ feat(plugin-chart-echarts): add graph echart Jan 27, 2021

junlincc mentioned this pull request Jan 27, 2021

[chart]old force-directed graph not re-render properly & echarts migration apache/superset#12788

Closed

mayurnewase changed the title ~~feat(plugin-chart-echarts): add graph echart~~ [WIP] feat(plugin-chart-echarts): add graph echart Jan 27, 2021

mayurnewase changed the title ~~[WIP] feat(plugin-chart-echarts): add graph echart~~ [WIP]feat(plugin-chart-echarts): add graph echart Jan 27, 2021

ktmud reviewed Feb 1, 2021

View reviewed changes

rusackas reviewed Feb 2, 2021

View reviewed changes

plugins/plugin-chart-echarts/src/Graph/EchartsGraph.tsx Outdated Show resolved Hide resolved

mayurnewase added 2 commits February 3, 2021 08:47

todos complete,clean+suggestsions up remaining

89e22b8

few typing issues,tests,legend customization remaining

782878d

vercel bot had a problem deploying to Preview February 3, 2021 06:15 Failure

cleanup

a8d0ac4

vercel bot had a problem deploying to Preview February 3, 2021 06:45 Failure

villebro mentioned this pull request Feb 3, 2021

[contributor wanted🙏]Tree diagram Echarts integration apache/superset#12847

Closed

cleanup

77ed1d7

vercel bot had a problem deploying to Preview February 3, 2021 12:02 Failure

arrow function

ff4ccb2

vercel bot had a problem deploying to Preview February 3, 2021 12:15 Failure

cleanup

e3828e7

vercel bot had a problem deploying to Preview February 3, 2021 12:24 Failure

villebro approved these changes Feb 17, 2021

View reviewed changes

Merge remote-tracking branch 'upstream/master' into echart-force-dire…

1688970

…cted

vercel bot had a problem deploying to Preview February 17, 2021 19:51 Failure

Support separate source category and target category

2401091

vercel bot had a problem deploying to Preview February 17, 2021 21:12 Failure

Fix JS error with null adhoc_filters

823956d

vercel bot deployed to Preview February 17, 2021 21:34 View deployment

ktmud reviewed Feb 17, 2021

View reviewed changes

ktmud mentioned this pull request Feb 18, 2021

[Explore]Customize X-axis debounce is broken apache/superset#13191

Closed

Fix type error

abb891e

vercel bot deployed to Preview February 18, 2021 01:25 View deployment

update tests

198fcb7

vercel bot deployed to Preview February 19, 2021 04:20 View deployment

mayurnewase commented Feb 19, 2021

View reviewed changes

plugins/plugin-chart-echarts/src/Graph/transformProps.ts Show resolved Hide resolved

test for core build query context

0256745

vercel bot deployed to Preview February 19, 2021 05:53 View deployment

bump min edge width and lint

484ccc0

vercel bot deployed to Preview February 19, 2021 06:18 View deployment

fix bugs

5945807

vercel bot deployed to Preview February 19, 2021 14:02 View deployment

added tests for core package

ffae31d

vercel bot requested a deployment to Preview February 19, 2021 15:51 Abandoned

vercel bot deployed to Preview February 19, 2021 15:52 View deployment

pretty

eabe0d4

vercel bot deployed to Preview February 19, 2021 16:03 View deployment

ktmud merged commit cb01eec into apache-superset:master Feb 19, 2021

villebro mentioned this pull request Feb 21, 2021

chore(viz): bump superset-ui 0.17.10 apache/superset#13258

Merged

6 tasks

junlincc mentioned this pull request Mar 2, 2021

superset Version1.01 How to integrate Echarts apache/superset#13383

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(plugin-chart-echarts): add graph echart #918

feat(plugin-chart-echarts): add graph echart #918

mayurnewase commented Jan 27, 2021 •

edited by junlincc

Loading

vercel bot commented Jan 27, 2021 •

edited

Loading

mayurnewase commented Jan 27, 2021

villebro commented Jan 27, 2021

mayurnewase commented Jan 31, 2021 •

edited

Loading

junlincc commented Jan 31, 2021

villebro commented Jan 31, 2021

ktmud left a comment •

edited

Loading

rusackas commented Feb 2, 2021

villebro left a comment

villebro Feb 17, 2021

villebro Feb 17, 2021

ktmud commented Feb 17, 2021 •

edited

Loading

ktmud Feb 17, 2021

ktmud commented Feb 19, 2021

feat(plugin-chart-echarts): add graph echart #918

feat(plugin-chart-echarts): add graph echart #918

Conversation

mayurnewase commented Jan 27, 2021 • edited by junlincc Loading

Todos

vercel bot commented Jan 27, 2021 • edited Loading

mayurnewase commented Jan 27, 2021

villebro commented Jan 27, 2021

mayurnewase commented Jan 31, 2021 • edited Loading

junlincc commented Jan 31, 2021

villebro commented Jan 31, 2021

ktmud left a comment • edited Loading

Choose a reason for hiding this comment

rusackas commented Feb 2, 2021

villebro left a comment

Choose a reason for hiding this comment

villebro Feb 17, 2021

Choose a reason for hiding this comment

villebro Feb 17, 2021

Choose a reason for hiding this comment

ktmud commented Feb 17, 2021 • edited Loading

ktmud Feb 17, 2021

Choose a reason for hiding this comment

ktmud commented Feb 19, 2021

mayurnewase commented Jan 27, 2021 •

edited by junlincc

Loading

vercel bot commented Jan 27, 2021 •

edited

Loading

mayurnewase commented Jan 31, 2021 •

edited

Loading

ktmud left a comment •

edited

Loading

ktmud commented Feb 17, 2021 •

edited

Loading