Fixed broken links #409
Merged
Fixed broken links #409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes apache#403
|
Everything you have so far looks good. I noticed another thing that seems to be broken while looking at your changes. The link for |
ctubbsii
approved these changes
Dec 14, 2023
There was a problem hiding this comment.
Looks good. Feel free to add the fix for the additional one that @DomGarguilo found. I'll hold off merging until then.
DomGarguilo
requested changes
Dec 18, 2023
Co-authored-by: Dom G. <domgarguilo@apache.org>
|
It looks like the build was failing due to the ruby version in the github actions script. I updated it on main so once you merge main into this branch it should pass here. |
ctubbsii
reviewed
Dec 19, 2023
…r-properties file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #403