Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop MemoryManager from properties #1660

Merged
merged 1 commit into from Jul 17, 2020
Merged

Drop MemoryManager from properties #1660

merged 1 commit into from Jul 17, 2020

Conversation

milleruntime
Copy link
Contributor

This is work to handle one of the internal pluggable components in #1659.

This removes the property and interface. The interface had internal types, was only used by one class and had a method with no implementation.

@milleruntime milleruntime added this to In progress in 2.1.0 via automation Jul 16, 2020
ctubbsii
ctubbsii approved these changes Jul 16, 2020
View reviewed changes
Copy link
Member

@ctubbsii ctubbsii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this was kept around to make it easier for somebody to write their own, or perhaps we had intended to create alternative implementations at some point?

I'm okay with removing it. It was never really public API.

@milleruntime milleruntime merged commit 4eba932 into apache:master Jul 17, 2020
2.1.0 automation moved this from In progress to Done Jul 17, 2020
@milleruntime milleruntime deleted the drop-memManager branch July 17, 2020 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ctubbsii ctubbsii ctubbsii approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
2.1.0
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@milleruntime @ctubbsii