Improve fetching scans and compactions in Monitor #2294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Drop fetchScans and fetchCompactions threads and just let the page refresh get the data as needed. Created constant to prevent fetching more then once a minute. Created time constant for age off * Replace active scans table with datatables and add fetched column * Add fetched column to Active compactions table * Refactored fetch methods to catch thrift error and log. * Made entry point methods getCompactions and getScans synchronized to allow removal of synchronized code blocks.
|
Screenshots of the 2 pages: |
Manno15
approved these changes
Sep 29, 2021
ctubbsii
approved these changes
Sep 30, 2021
server/monitor/src/main/java/org/apache/accumulo/monitor/Monitor.java
Outdated
Show resolved
Hide resolved
milleruntime
added a commit
to milleruntime/accumulo
that referenced
this pull request
Oct 1, 2021
* Drop fetchScans and fetchCompactions threads and just let the page refresh get the data as needed. Created constant to prevent fetching more than once a minute. Created time constant for age off * Replace active scans table with datatables and add fetched column * Add fetched column to Active compactions table * Refactored fetch methods to catch thrift error and log. * Made entry point methods getCompactions and getScans synchronized to allow removal of synchronized code blocks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refresh get the data as needed. Created constant to prevent fetching
more then once a minute. Created time constant for age off
allow removal of synchronized code blocks.