Fix incorrect scan range output in getsplits command #2370
Conversation
In the Accumulo shell, calling getsplits with the verbose option can result in incorret output. It occurs when the tableId of the table happens to be a single character and there are other tables where the tableId starts with the same character. This results in the output of getsplits displaying splits for the other tables as well. Closes apache#2356
|
Questions more than a comment. Did you consider mocking and using a unit test rather than (or in conjunction with) the IT test? |
|
This PR seems to be a copy of #2369 |
|
@Manno15 one is for 2.x and the other for 1.x |
|
My apologies. I didn't look that cloesly. |
|
@EdColeman I must admit I did not consider mocking. The test does seems to be a bit of an overkill for a one line bug fix, but I wanted to verify it using the actual command calls. I haven't had a lot of experience using mocking in the past so that probably played a part in me not going that route. As for breaking up the IT, we could put in an issue if someone wanted to take on that task. |
|
The fix seems small enough that you didn't need both PRs but either way, I approved the other one. |
Added a couple of grammatical fixes based upon @millerruntime suggestions.
In the Accumulo shell, calling getsplits with the verbose option can result in incorret output. It occurs when the tableId of the table
happens to be a single character and there are other tables where the tableId starts with the same character. This results in the output of getsplits displaying splits for the other tables as well.
Closes #2356