Remove htrace4 from the binary distribution #3126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The htrace4 dependency is not needed for Accumulo. It may or may not be a dependency of Hadoop, but if it is needed for that, it can be brought in via the Hadoop lib directory and added to Accumulo's runtime class path. However, since it is not needed for Accumulo itself, it should not be redistributed by Accumulo.
EdColeman
approved these changes
Dec 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The htrace4 dependency is not needed for Accumulo. It may or may not be a dependency of Hadoop, but if it is needed for that, it can be brought in via the Hadoop lib directory and added to Accumulo's runtime class path. However, since it is not needed for Accumulo itself, it should not be redistributed by Accumulo.