Fixes #3630 - ClientContext updated to handle time duration values correctly #3631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlmarion
reviewed
Jul 19, 2023
core/src/test/java/org/apache/accumulo/core/clientImpl/ClientContextTest.java
Show resolved
Hide resolved
core/src/test/java/org/apache/accumulo/core/clientImpl/ClientContextTest.java
Show resolved
Hide resolved
|
Same bug here which I missed, for conditional writer timeout. The test uses an prop value of "17" (defaulting to time unit of SECONDS) and then asserts that 17000 seconds is expected |
- ClientContext updated to handle time duration values correctly - ClientContextTest updated accordingly
keith-ratcliffe
force-pushed
the
bugfix/ClientContext
branch
from
53c87a1
to
da7c1a2
Compare
|
Rebased/squash commit now includes the fix for CONDITIONAL_WRITER_TIMEOUT_MAX and also cleanup/refinement of the affected junits in ClientContextTest |
dlmarion
approved these changes
Jul 19, 2023
|
@keith-ratcliffe - Thanks for your contribution. I see this is your first time contributing. Feel free to put up a PR on https://github.com/apache/accumulo-website to add yourself to the people page. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.