Make TLSv1.2 the default #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When Accumulo's RPC is configured for SSL/TLS, the client connections will choose TLSv1.2 by default (instead of TLSv1 or TLSv1.1).
|
I added a second commit which instructs the server-side to use TLS 1.2 by default, also. As I understand it, there's a few well-known downgrade attacks for 1.1 and 1.0, that we should avoid. Since we maintain the code for both client and server, there's no reason we shouldn't use 1.2 by default. It is still configurable, if users need something else. |
ctubbsii
changed the title
PircDef
approved these changes
Apr 9, 2018
|
Is there an intent to remove ProtocolOverridingSSLSocketFactory as well? |
|
@PircDef Maybe... that would be a bigger change, and more testing to ensure correctness. This is a simple configuration defaults change vs. changing currently functioning code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Accumulo's RPC is configured for SSL/TLS, the client connections
will choose TLSv1.2 by default (instead of TLSv1 or TLSv1.1).