Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add scan server metrics to track reservation write times and collisions #4509

Closed
keith-turner opened this issue Apr 30, 2024 · 3 comments · Fixed by #4577
Closed

Add scan server metrics to track reservation write times and collisions #4509

keith-turner opened this issue Apr 30, 2024 · 3 comments · Fixed by #4577
Assignees
@DomGarguilo
Labels
enhancement This issue describes a new feature, improvement, or optimization.
Projects
3.1.0 2.1.3

Comments

@keith-turner
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Reserving files is an extra step that scan servers take that can add time to scans. In order to understand the cost of this metrics are useful. The current metrics are not adequate to fully understand the problem.

Describe the solution you'd like
The changes in #4461 add metrics to track the total time reserving a tablets files takes. In addition to these metrics it would be useful to also track the time it takes to write out reservations and count when collisions happen. The changes in #4461 should indirectly track the time it takes to read metadata via the cache metrics it added, so there may not be a need to explicitly track read time.
@keith-turner keith-turner added the enhancement This issue describes a new feature, improvement, or optimization. label Apr 30, 2024
@keith-turner keith-turner added this to To do in 3.1.0 via automation Apr 30, 2024
@keith-turner keith-turner added this to To do in 2.1.3 via automation Apr 30, 2024
@DomGarguilo
Copy link
Member

I can take a look at this

@DomGarguilo DomGarguilo self-assigned this May 2, 2024
@DomGarguilo DomGarguilo mentioned this issue May 9, 2024
Closed
@DomGarguilo DomGarguilo mentioned this issue May 20, 2024
Merged
@DomGarguilo DomGarguilo linked a pull request May 20, 2024 that will close this issue
Add metrics for scan server reservation write out time and collisions #4577
Merged
@dlmarion
Copy link
Contributor

@DomGarguilo - can this be closed now that #4577 is merged?

@DomGarguilo
Copy link
Member

Closing as completed via #4577

3.1.0 automation moved this from To do to Done May 28, 2024
2.1.3 automation moved this from To do to Done May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DomGarguilo DomGarguilo

Labels
enhancement This issue describes a new feature, improvement, or optimization.
Projects
2.1.3
Done
3.1.0
Done
Accumulo Elasticity
Status: ✅ Done
Milestone
No milestone
3 participants
@dlmarion @keith-turner @DomGarguilo