Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service status command is not functional in elasticity after merge #4612

Closed
keith-turner opened this issue May 28, 2024 · 2 comments · Fixed by #4613
Closed

Service status command is not functional in elasticity after merge #4612

keith-turner opened this issue May 28, 2024 · 2 comments · Fixed by #4613
Assignees
Labels
bug This issue has been verified to be a bug.
Milestone

Comments

@keith-turner
Copy link
Contributor

Describe the bug

In commit c54d544 the changes from #4567 were merged into elasticity. The changes did not compile because the compaction coordinator no longer exists as separate process in elasticity. Rather than attempt to fix this in a merge commit, changes were made to get the code compiling that likely left the command non functional. Probably need to remove a lot of code and test to properly fix this.

The following are the two changes that made things compile, but left things in a broken state.

StatusSummary getCoordinatorStatus(final ZooReader zooReader, String zRootPath) {
throw new UnsupportedOperationException();
}

// String lockPath = zRoot + Constants.ZCOORDINATOR_LOCK;
String lockPath = null;

Expected behavior
The service status command works in elasticity.

@keith-turner keith-turner added the bug This issue has been verified to be a bug. label May 28, 2024
@EdColeman EdColeman self-assigned this May 28, 2024
@EdColeman
Copy link
Contributor

On it.

@EdColeman
Copy link
Contributor

This requires 814ac68 to be merged first which should be most of the changes becuase of ServiceLock usage changes. After that is merged, the removal of the coordinator should just be some deletes - the methods that collects the info getCoordinatorStatus, places where it is called and removal of the test case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue has been verified to be a bug.
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants