Skip to content

Commit

Permalink
ARTEMIS-4467 Core client code visibility change required.
Browse files Browse the repository at this point in the history
* Since the constructors in RemotingConnectionImpl can be used from the server and the client.
If the server calling code is in a different classloader then the
constructor can't be called.
* same for the 'active' boolean property of ActiveMQChannelHandler

Issue: https://issues.apache.org/jira/browse/ARTEMIS-4467

Signed-off-by: Emmanuel Hugonnet <ehugonne@redhat.com>
  • Loading branch information
ehsavoie authored and clebertsuconic committed Oct 25, 2023
1 parent 6649ecf commit 3727370
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ public RemotingConnectionImpl(final PacketDecoder packetDecoder,
/*
* Create a server side connection
*/
RemotingConnectionImpl(final PacketDecoder packetDecoder,
public RemotingConnectionImpl(final PacketDecoder packetDecoder,
final Connection transportConnection,
final List<Interceptor> incomingInterceptors,
final List<Interceptor> outgoingInterceptors,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ public class ActiveMQChannelHandler extends ChannelDuplexHandler {

private final BaseConnectionLifeCycleListener<?> listener;

volatile boolean active;
protected volatile boolean active;

private final Executor listenerExecutor;

Expand Down

0 comments on commit 3727370

Please sign in to comment.