Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
ARTEMIS-2064 make address & queue deployment more robust
Any failure to deploy an address or queue will short-circuit the broker initialization process preventing any other addresses or queues from being deployed as well as other critical resources like acceptors, etc. (cherry picked from commit b0d30d4)
- Loading branch information
Showing
7 changed files
with
168 additions
and
27 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
45 changes: 45 additions & 0 deletions
45
...st/java/org/apache/activemq/artemis/tests/extras/byteman/AddressDeploymentFailedTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,45 @@ | ||
/* | ||
* Licensed to the Apache Software Foundation (ASF) under one or more | ||
* contributor license agreements. See the NOTICE file distributed with | ||
* this work for additional information regarding copyright ownership. | ||
* The ASF licenses this file to You under the Apache License, Version 2.0 | ||
* (the "License"); you may not use this file except in compliance with | ||
* the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
package org.apache.activemq.artemis.tests.extras.byteman; | ||
|
||
import java.util.UUID; | ||
|
||
import org.apache.activemq.artemis.api.core.RoutingType; | ||
import org.apache.activemq.artemis.core.config.CoreAddressConfiguration; | ||
import org.apache.activemq.artemis.core.server.ActiveMQServer; | ||
import org.apache.activemq.artemis.tests.util.ActiveMQTestBase; | ||
import org.jboss.byteman.contrib.bmunit.BMRule; | ||
import org.jboss.byteman.contrib.bmunit.BMUnitRunner; | ||
import org.junit.Test; | ||
import org.junit.runner.RunWith; | ||
|
||
@RunWith(BMUnitRunner.class) | ||
public class AddressDeploymentFailedTest extends ActiveMQTestBase { | ||
|
||
@Test | ||
@BMRule(name = "blow up address deployment", | ||
targetClass = "org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl", | ||
targetMethod = "addOrUpdateAddressInfo(AddressInfo)", | ||
targetLocation = "EXIT", | ||
action = "throw new IllegalStateException(\"test exception\")") | ||
public void testAddressDeploymentFailure() throws Exception { | ||
ActiveMQServer server = createServer(false, createDefaultNettyConfig()); | ||
server.getConfiguration().addAddressConfiguration(new CoreAddressConfiguration().setName(UUID.randomUUID().toString()).addRoutingType(RoutingType.ANYCAST)); | ||
server.start(); | ||
assertTrue(server.getRemotingService().isStarted()); | ||
} | ||
} |
47 changes: 47 additions & 0 deletions
47
...test/java/org/apache/activemq/artemis/tests/extras/byteman/QueueDeploymentFailedTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,47 @@ | ||
/* | ||
* Licensed to the Apache Software Foundation (ASF) under one or more | ||
* contributor license agreements. See the NOTICE file distributed with | ||
* this work for additional information regarding copyright ownership. | ||
* The ASF licenses this file to You under the Apache License, Version 2.0 | ||
* (the "License"); you may not use this file except in compliance with | ||
* the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
package org.apache.activemq.artemis.tests.extras.byteman; | ||
|
||
import java.util.UUID; | ||
|
||
import org.apache.activemq.artemis.api.core.RoutingType; | ||
import org.apache.activemq.artemis.core.config.CoreAddressConfiguration; | ||
import org.apache.activemq.artemis.core.config.CoreQueueConfiguration; | ||
import org.apache.activemq.artemis.core.server.ActiveMQServer; | ||
import org.apache.activemq.artemis.tests.util.ActiveMQTestBase; | ||
import org.jboss.byteman.contrib.bmunit.BMRule; | ||
import org.jboss.byteman.contrib.bmunit.BMUnitRunner; | ||
import org.junit.Test; | ||
import org.junit.runner.RunWith; | ||
|
||
@RunWith(BMUnitRunner.class) | ||
public class QueueDeploymentFailedTest extends ActiveMQTestBase { | ||
|
||
@Test | ||
@BMRule(name = "blow up queue deployment", | ||
targetClass = "org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl", | ||
targetMethod = "createQueue(SimpleString,RoutingType,SimpleString,SimpleString,SimpleString,boolean,boolean,boolean,boolean,boolean,int,boolean,boolean,boolean,int,long,boolean", | ||
targetLocation = "EXIT", | ||
action = "throw new IllegalStateException(\"test exception\")") | ||
public void testQueueDeploymentFailure() throws Exception { | ||
ActiveMQServer server = createServer(false, createDefaultNettyConfig()); | ||
String address = UUID.randomUUID().toString(); | ||
server.getConfiguration().addAddressConfiguration(new CoreAddressConfiguration().setName(address).addRoutingType(RoutingType.ANYCAST).addQueueConfiguration(new CoreQueueConfiguration().setName(UUID.randomUUID().toString()).setRoutingType(RoutingType.ANYCAST).setAddress(address))); | ||
server.start(); | ||
assertTrue(server.getRemotingService().isStarted()); | ||
} | ||
} |