NO-JIRA Add forgotten @test annotation and make helper methods private

apache · Dec 13, 2018 · 56c7fb1 · 56c7fb1
1 parent 94c158e
commit 56c7fb1
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 6 deletions.
diff --git a/...he/activemq/artemis/protocol/amqp/converter/message/JMSMappingInboundTransformerTest.java b/...he/activemq/artemis/protocol/amqp/converter/message/JMSMappingInboundTransformerTest.java
@@ -150,6 +150,7 @@ public void testCreateBytesMessageFromDataWithEmptyBinaryAndContentType() throws
     * @throws Exception
     *         if an error occurs during the test.
     */
+   @Test
    public void testCreateBytesMessageFromDataWithUnknownContentType() throws Exception {
       MessageImpl message = (MessageImpl) Message.Factory.create();
       Binary binary = new Binary(new byte[0]);

diff --git a/artemis-rest/src/test/java/org/apache/activemq/artemis/rest/test/ClientAckQueueTest.java b/artemis-rest/src/test/java/org/apache/activemq/artemis/rest/test/ClientAckQueueTest.java
@@ -52,7 +52,7 @@ public void testAckTimeoutX2() throws Exception {
       testAckTimeout();
    }
 
-   public void testAckTimeout() throws Exception {
+   private void testAckTimeout() throws Exception {
       ClientRequest request = new ClientRequest(generateURL("/queues/testAck"));
 
       ClientResponse<?> response = Util.head(request);
@@ -127,7 +127,7 @@ public void testSuccessFirstX2() throws Exception {
       testSuccessFirst(3, testName);
    }
 
-   public void testSuccessFirst(int start, String queueName) throws Exception {
+   private void testSuccessFirst(int start, String queueName) throws Exception {
       ClientRequest request = new ClientRequest(generateURL(Util.getUrlPath(queueName)));
 
       ClientResponse<?> response = Util.head(request);
@@ -205,7 +205,7 @@ public void testPullX2() throws Exception {
       testPull(4, testName);
    }
 
-   public void testPull(int start, String queueName) throws Exception {
+   private void testPull(int start, String queueName) throws Exception {
       ClientRequest request = new ClientRequest(generateURL(Util.getUrlPath(queueName)));
 
       ClientResponse<?> response = Util.head(request);
@@ -287,7 +287,7 @@ public void testReconnectX2() throws Exception {
       testReconnect(testName);
    }
 
-   public void testReconnect(String queueName) throws Exception {
+   private void testReconnect(String queueName) throws Exception {
       ClientRequest request = new ClientRequest(generateURL(Util.getUrlPath(queueName)));
 
       ClientResponse<?> response = Util.head(request);

diff --git a/artemis-rest/src/test/java/org/apache/activemq/artemis/rest/test/ClientAckTopicTest.java b/artemis-rest/src/test/java/org/apache/activemq/artemis/rest/test/ClientAckTopicTest.java
@@ -51,7 +51,7 @@ public void testAckTimeoutX2() throws Exception {
       testAckTimeout();
    }
 
-   public void testAckTimeout() throws Exception {
+   private void testAckTimeout() throws Exception {
 
       ClientRequest request = new ClientRequest(TestPortProvider.generateURL("/topics/testAck"));
 

diff --git a/...e/activemq/artemis/tests/integration/cluster/distribution/SimpleSymmetricClusterTest.java b/...e/activemq/artemis/tests/integration/cluster/distribution/SimpleSymmetricClusterTest.java
@@ -18,6 +18,7 @@
 
 import org.apache.activemq.artemis.core.server.cluster.impl.MessageLoadBalancingType;
 import org.apache.activemq.artemis.tests.integration.IntegrationTestLogger;
+import org.junit.Ignore;
 import org.junit.Test;
 
 public class SimpleSymmetricClusterTest extends ClusterTestBase {
@@ -282,7 +283,9 @@ public void testSimpleRoundRobbin() throws Exception {
       verifyReceiveRoundRobinInSomeOrder(33, 2, 0, 1);
    }
 
-   public void _testSimpleRoundRobbinNoFailure() throws Exception {
+   @Test
+   @Ignore("Test not implemented yet")
+   public void testSimpleRoundRobbinNoFailure() throws Exception {
       //TODO make this test to crash a node
       setupServer(0, true, isNetty());
       setupServer(1, true, isNetty());