Skip to content

Commit

Permalink
NO-JIRA: enable optional modules during release, get their version up…
Browse files Browse the repository at this point in the history
…dated and are tagged as such. Refresh release docs.
  • Loading branch information
gemmellr committed Oct 20, 2021
1 parent 1ef059d commit 6bd7638
Show file tree
Hide file tree
Showing 4 changed files with 19 additions and 15 deletions.
18 changes: 6 additions & 12 deletions RELEASING.md
Expand Up @@ -79,12 +79,12 @@ When prompted make sure the next is a major release. Example:

```
[INFO] Checking dependencies and plugins for snapshots ...
What is the release version for "ActiveMQ Artemis Parent"? (org.apache.activemq:artemis-pom) 1.4.0: :
What is SCM release tag or label for "ActiveMQ Artemis Parent"? (org.apache.activemq:artemis-pom) artemis-pom-1.4.0: : 1.4.0
What is the new development version for "ActiveMQ Artemis Parent"? (org.apache.activemq:artemis-pom) 1.4.1-SNAPSHOT: : 1.5.0-SNAPSHOT
What is the release version for "ActiveMQ Artemis Parent"? (org.apache.activemq:artemis-pom) 2.19.0: :
What is SCM release tag or label for "ActiveMQ Artemis Parent"? (org.apache.activemq:artemis-pom) artemis-pom-2.19.0: : 2.19.0
What is the new development version for "ActiveMQ Artemis Parent"? (org.apache.activemq:artemis-pom) 2.19.1-SNAPSHOT: : 2.20.0-SNAPSHOT
```

Otherwise snapshots will be created at 1.4.1 and forgotten. (Unless we ever release 1.4.1 on that example).
Otherwise snapshots will be created at 2.19.1-SNAPSHOT and forgotten. (Unless we ever release 2.19.1 on that example).

For more information look at the prepare plugin:

Expand All @@ -98,13 +98,6 @@ git push upstream
git push upstream <version>
```


## Extra tests

Note: The Apache Release plugin does not bump the version on the `extraTests` module. Release manager should manually
bump the version in the test/extra-tests/pom.xml to the next development version.


## Uploading to nexus

Ensure that your environment is ready to deploy to the ASF Nexus repository as described at
Expand Down Expand Up @@ -263,12 +256,13 @@ informing the list about the voting results, e.g.:
```
Results of the Apache ActiveMQ Artemis <version> release vote.
Vote passes with 3 votes, 2 binding and 1 non binding.
Vote passes with 4 votes, 3 binding and 1 non-binding.
The following votes were received:
Binding:
+1 John Doe
+1 Jane Doe
+1 Bill Smith
Non Binding:
Expand Down
3 changes: 0 additions & 3 deletions artemis-distribution/src/main/assembly/source-assembly.xml
Expand Up @@ -37,9 +37,6 @@
<directoryMode>0755</directoryMode>
<fileMode>0644</fileMode>
<excludes>
<exclude>tests/extra-tests/</exclude>
<exclude>tests/performance-jmh/</exclude>

<exclude>artemis-distribution/src/main/resources/bin/artemis</exclude>
<exclude>artemis-cli/src/main/resources/org/apache/activemq/artemis/cli/commands/bin/artemis</exclude>
<exclude>artemis-cli/src/main/resources/org/apache/activemq/artemis/cli/commands/bin/artemis-service</exclude>
Expand Down
10 changes: 10 additions & 0 deletions tests/extra-tests/pom.xml
Expand Up @@ -302,6 +302,16 @@
<argLine>${activemq-surefire-argline} -noverify</argLine>
</configuration>
</plugin>

<!-- Don't deploy artifacts for this module. It has non-permissive
dependencies and is only optionally used for local testing. -->
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-deploy-plugin</artifactId>
<configuration>
<skip>true</skip>
</configuration>
</plugin>
</plugins>
</build>

Expand Down
3 changes: 3 additions & 0 deletions tests/pom.xml
Expand Up @@ -131,9 +131,12 @@
<id>release</id>
<modules>
<module>activemq5-unit-tests</module>
<module>extra-tests</module>
<module>performance-jmh</module>
</modules>
<properties>
<skipActiveMQ5Tests>true</skipActiveMQ5Tests>
<skipExtraTests>true</skipExtraTests>
</properties>
</profile>
</profiles>
Expand Down

0 comments on commit 6bd7638

Please sign in to comment.