ARTEMIS-4215 Test adjustments

apache · May 26, 2023 · 88f9fa4 · 88f9fa4
1 parent 747e0bd
commit 88f9fa4
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 7 deletions.
diff --git a/...st/java/org/apache/activemq/artemis/tests/smoke/infinite/InfiniteRedeliverySmokeTest.java b/...st/java/org/apache/activemq/artemis/tests/smoke/infinite/InfiniteRedeliverySmokeTest.java
@@ -146,7 +146,6 @@ public void testValidateJournalOnRollbackSend() throws Exception {
          // it should be max 10 actually, I'm just leaving some space for future changes,
          // as the real test I'm after here is the broker should clean itself up
          Wait.assertTrue(() -> fileFactory.listFiles("amq").size() <= 20);
-         Assert.assertTrue("there are too many files created", numberOfFiles <= 20);
       }
    }
 }
diff --git a/...test/java/org/apache/activemq/artemis/tests/soak/interrupt/JournalFlushInterruptTest.java b/...test/java/org/apache/activemq/artemis/tests/soak/interrupt/JournalFlushInterruptTest.java
@@ -30,6 +30,7 @@
 import org.apache.activemq.artemis.api.core.management.QueueControl;
 import org.apache.activemq.artemis.tests.soak.SoakTestBase;
 import org.apache.activemq.artemis.tests.util.CFUtil;
+import org.apache.activemq.artemis.tests.util.Wait;
 import org.junit.Assert;
 import org.junit.Before;
 import org.junit.Test;
@@ -72,7 +73,7 @@ public void testInterruptJF() throws Throwable {
 
       QueueControl queueControl = getQueueControl(liveURI, liveNameBuilder, queueName, queueName, RoutingType.ANYCAST, 5000);
 
-      Assert.assertEquals(messageCount, queueControl.getMessageCount());
+      Wait.assertEquals(messageCount, queueControl::getMessageCount, 5000);
       Thread.sleep(100);
 
       killProcess(serverProcess);
@@ -82,7 +83,7 @@ public void testInterruptJF() throws Throwable {
       waitForServerToStart("tcp://localhost:61616", "artemis", "artemis", 5000);
       queueControl = getQueueControl(liveURI, liveNameBuilder, queueName, queueName, RoutingType.ANYCAST, 5000);
 
-      Assert.assertEquals(messageCount, queueControl.getMessageCount());
+      Wait.assertEquals(messageCount, queueControl::getMessageCount);
 
    }
 

diff --git a/...c/test/java/org/apache/activemq/artemis/tests/unit/core/journal/impl/TimedBufferTest.java b/...c/test/java/org/apache/activemq/artemis/tests/unit/core/journal/impl/TimedBufferTest.java
@@ -34,6 +34,7 @@
 import org.apache.activemq.artemis.tests.util.ActiveMQTestBase;
 import org.apache.activemq.artemis.utils.Env;
 import org.apache.activemq.artemis.utils.ReusableLatch;
+import org.apache.activemq.artemis.utils.Wait;
 import org.junit.Assert;
 import org.junit.Test;
 import org.slf4j.Logger;
@@ -180,7 +181,7 @@ public void onError(int errorCode, String errorMessage) {
 
          // simulating a low load period
          timedBuffer.addBytes(buff, true, callback);
-         Thread.sleep(1000);
+         Thread.sleep(100);
          timedBuffer.addBytes(buff, true, callback);
          Assert.assertTrue(latchFlushed.await(5, TimeUnit.SECONDS));
          latchFlushed.setCount(5);
@@ -494,9 +495,7 @@ public int getRemainingBytes() {
          timedBuffer.checkSize(10);
          timedBuffer.addBytes(buff, false, dummyCallback);
 
-         Thread.sleep(200);
-
-         Assert.assertEquals(count + 1, flushTimes.get());
+         Wait.assertEquals(count + 1, () -> flushTimes.get(), 2000);
 
          bytes = new byte[10];
          for (int j = 0; j < 10; j++) {